muhlemmer / pbpgx Goto Github PK

View Code? Open in Web Editor NEW

11.0 2.0 1.0 268 KB

Package pbpgx provides a toolkit for easier Protocol Buffers interaction with PostgreSQL databases.

License: GNU Affero General Public License v3.0

Dockerfile 1.14% Go 98.86%

postgresql postgres pgx protobuf protocol-buffers grpc grpc-go protoreflect generics golang

pbpgx's People

Contributors

Stargazers

Watchers

Forkers

wfen

pbpgx's Issues

Should I continue on this lib

I have doubts to continue work on this library. To be honest, since I started pgx v5 came out which now features excellent mechanics to scan directly into struct types including nesting of rows etc. Hence, I don't see much value in regards to scanning into protobuffer messages specifically. Also the architecture at my current employer is mostly incompatible with what I tried to do here, so there is no incentive to support this work at the moment.

The query building part was nice to do and I spend quite some time optimizing it. So there arises my doubt :)

There are just 11 Github stars, for which I'm grateful. Please let me know if there are any real usecases out there already and I will make up my mind based on feedback. Cheers!

Drop the selector interface

The selector interface puts too much limits on the callers. Instead, just use generic arguments for ID and columns.

pbpgx/crud/read.go

Lines 32 to 46 in 0cde4e5

    
           type Selector[ID any, ColDesc fmt.Stringer] interface { 
        
           	proto.Message 
        
           	// GetId may return any type for ID. 
        
           	// The returned value will be used as-is as unique identifier in the "id" 
        
           	// column of the table being accessed. 
        
           	// The type must by compatible with the PostgreSQL type of the "id" column. 
        
           	// This method is ussualy generated for proto messages with an `id` field defined. 
        
           	GetId() ID 
        
           	// GetColumns returns a slice of fmt.Stringer, as column descriptors. 
        
           	// This method is ussualy generated for proto messages with a `columns` field defined. 
        
           	// This field should be a "repeated enum" type. Each enum value equals a column name. 
        
           	GetColumns() []ColDesc 
        
           }

crud: false NoRows error returned if other error occurs

pbpgx/crud/create.go

Line 106 in 38fe474

record, err = pbpgx.QueryRow[Record](ctx, x, qs, args...)

Executing the INSERT...RETURNING query which fails to insert, the returned error is pgx.ErrNoRows, while it should be the original error:

6:27PM ERR Query args=[{"ValueTranscoder":"muhlemmer"},{"ValueTranscoder":"[email protected]"}] err="ERROR: duplicate key value violates unique constraint \"users_email_key\" (SQLSTATE 23505)" module=pgx pid=373 sql="INSERT INTO \"account\".\"users\" (\"nickname\", \"email\") VALUES ($1, $2) RETURNING \"email\", \"nickname\", \"updated_at\", \"created_at\", \"id\";"
panic: Table "account"."users" Create[0]: no rows in result set

CI fails on panic

Seems some parts of the code are still throwing a panic, instead of returning error.

https://github.com/muhlemmer/pbpgx/runs/4570868206?check_suite_focus=true#step:6:24

muhlemmer / pbpgx Goto Github PK

pbpgx's People

Contributors

Stargazers

Watchers

Forkers

pbpgx's Issues

Should I continue on this lib

Drop the selector interface

crud: false NoRows error returned if other error occurs

CI fails on panic

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent

	type Selector[ID any, ColDesc fmt.Stringer] interface {
	proto.Message

	// GetId may return any type for ID.
	// The returned value will be used as-is as unique identifier in the "id"
	// column of the table being accessed.
	// The type must by compatible with the PostgreSQL type of the "id" column.
	// This method is ussualy generated for proto messages with an `id` field defined.
	GetId() ID

	// GetColumns returns a slice of fmt.Stringer, as column descriptors.
	// This method is ussualy generated for proto messages with a `columns` field defined.
	// This field should be a "repeated enum" type. Each enum value equals a column name.
	GetColumns() []ColDesc
	}