About

We need to change the current 2 Apps (Staking and main) to use the published subgraphs. For this we need to topup our billing account on Polygon

Subissues

• #213
• Topup TheGraph billing account

Describe the bug
On Governance app, when reaching https://staking.mstable.app/#/dials, the EpochDetails and Dials sections stay pending when current Epoch is selected. Note that you need to clear your local storage in order to reproduce the bug.

To Reproduce
Steps to reproduce the behavior:

1. Clear local storage
2. Got to https://staking.mstable.app/#/dials
3. Screen stays in loading state

Expected behavior
App should display dials and epoch details for current epoch

We want to sunset old staking contracts (EARN) and propose a easy withdraw process for users still having funds there.

=> Create a notification button when user has positive balance on old contracts

=> Clicking on it opens modal with staked assets list, each card proposes a Withdraw action button calling the withdraw method on the contract

There is no way of going from the staking app to the main app and vice versa.

I link in the footer would be an easy solution. Maybe there is a better place? Any ideas?

Describe the bug
A clear and concise description of what the bug is.

To Reproduce
Steps to reproduce the behaviour:

1. Go to https://mstable.app/#/
2. Click on Pools
3. Hover over the rows, and items jump around.
4. (in particular when hovering on and off from the deprecated pool)
5. (or also when hovering over a pool that has not yet loaded the APY)

Expected behaviour
Everything stays the same size.

Screenshots

name: Bug report
about: Create a report to help us improve
title: Wallet and Network behaviour is inconsistent/unexpected
labels: UI, staking, app

Describe the bug
The Wallet behaviour is unexpected for some actions. This applied to both, the staking and the main app. But point 5 is specific to the staking app.

• When changing to a non-supported network from MM, the app prompts to change to Ethereum back

Should not prompt to change the network, because this app might be in another Tab and the users try to change network using another app. After rejection, there is no indication in the app that the wrong network has been selected. The wrong network appears for a split second but changes back to the default network.

• When selecting a non-supported network, the app has no indication that a non-supported network is selected.

Should have something to tell the user that the current network is not supported

• When Polygon is selected in MM, upon opening the app it prompts to change to mainnet (should detect that Polygon is selected)

This does not happen every time, I am not sure what triggers this.

• Staking App allows Polygon to have selected, but it doesn't support polygon.

The app is still normally accessible but all the content does not get loaded, no indication that the network is not supported

• When changing networks, the wallet shows for a split second that the wrong network is connected

This should really happen only when a wrong network is selected and persist until it is changed

• When changing from polygon to mainnet, subgraph errors appear.

• When promoting to change networks from the app, MM change network appears and elements of the APP get rerendered.

Describe the bug
A clear and concise description of what the bug is.

To Reproduce
Steps to reproduce the behavior:
0. Have your wallet disconnected from mstable.app

1. Set your wallet on polygon
2. Go to https://mstable.app
3. Change to polygon
4. Click connect

You are asked to change to mainnet

Expected behavior
Connect to polygon

Screenshots

Describe the bug
Profile pictures for delegates are missing

To Reproduce
Steps to reproduce the behaviour:

1. Go to https://staking.mstable.app/#/vote
2. See missing profile picture
3. Also in View Leaderboard and when selecting a single delegate

Expected behaviour
Picture should appear

Screenshots

Describe the bug
BAL APY is at 0%

To Reproduce
Steps to reproduce the behaviour:

1. Go to https://staking.mstable.app/#/stake
2. Click on BPT

Expected behaviour
Should find a way where to pull the BAL APY. Pre Staking Upgrade it was working based on a weekly amount?

Additional context
Might need to look into an API for fetching the distribution amount of BAL and how much of the Pool is staked

Describe the bug
Having imusd in the vault, I am not able to withdraw.
The funds appear as if they are staked, when I try to unstake, a red pop up appears with the mention "transaction failed"

To Reproduce
Steps to reproduce the behavior:

1. Go to deposit tab
2. Click on deposit money in imusd
3. go to stake tab
4. stake
5. try to unstake
   6 see error "transaction failed with the amount unable to be withdrawn

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
The transactions seem stuck as "pending"

Desktop (please complete the following information):

• OS: [e.g. iOS]
• Browser Brave Chromium to 99.0.4844.88.
• Version [e.g. 22]

Smartphone (please complete the following information):

• Device: [e.g. iPhone6]
• OS: [e.g. iOS8.1]
• Browser [e.g. stock browser, safari]
• Version [e.g. 22]

Additional context
Add any other context about the problem here.

Describe the bug
When trying to send a transaction on Polygon some information is wrong:

• Ethereum is displayed (should display matic)
• Transaction cost estimation is done with the Ethereum price, looks very expensive.

To Reproduce
Steps to reproduce the behavior:

1. Go to https://mstable.app/#/musd/swap
2. Select polygon
3. Try to swap
4. Click on Redeem/Swap
5. See Transaction modal.
   

Expected behavior
Should estimate Polygon fees in Matic and change icon to Matic.

Is your feature request related to a problem? Please describe.
A user wants in most cases to stake the tokens. The UI however defaults to the step before. (Save and Pools)

Describe the solution you'd like
Should directly select the Vault, similar when redeeming, should directly offer to redeem from the Vault. Alternatively, can fetch the balance and suggest to redeem from the Vault or Save (Pool).

Describe the bug
Many dials got disabled, however, the UI still shows the same APY for MTA rewards. This is because the rewards Rate does not get updated anymore. The UI has to be aware that if the last time the rewardsRate was updated longer than 7 days, the rewards are empty and no new rewards got added.

To Reproduce
Steps to reproduce the behavior:

https://mstable.app/#/mbtc/save

https://mstable.app/#/mbtc/pools

https://mstable.app/#/musd/pools

Also Single Pools Page, e.g. https://mstable.app/#/musd/pools/0x4eaa01974b6594c0ee62ffd7fee56cf11e6af936

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots

Since renBTC project is closing, we need to warn users to withdraw their assets.

The fp contract can block a withdraw if weights of a certain token are getting imbalanced, it asks for an exact withdraw where assets are pulled proportionnally from the pool with the exact methods.

The app does not currently support Unstoppable Domains as a login option so people who would like to login with UD extensions: .crypto, .x, .nft and .wallet have to use Metamask or other login options.

Adding Unstoppable Domains as a login option would solve this and make the app more accessible. Bonus is that the app could get featured on their website to reach out to more people. I would like to develop this feature with a pull request if possible!

Describe the bug
The dials page shows distribution for current and past epoch for disabled dials.

To Reproduce
Steps to reproduce the behavior:

1. Go to https://staking.mstable.app/#/dials
2. See top box

Expected behavior
Dials that are disabled should not receive MTA, there is no distribution. So for the past and the current epoch it should show the correct distribution and amount

Screenshots

The Save Vault Rewards Vesting calculation seems to be not accurate, on-chain transactions verify a different amount of MTA that is sent to the user.

More info to be added here @dimsome

Bug description

1. https://staking.mstable.app/#/quests
2. Needs to connect to a wallet that has staked and received a timeMultiplier

Hold time is always 1x. Does not reflect the real timeMultiplier

Acceptance Criteria

• Shows correct timeMultiplier for the connected account.

We recently disabled a few underutilized dials with MCCP 22: https://mips.mstable.org/MCCP/mccp-22.html

The now disabled dials are the following:

Dial | Recipient address | Dial Id

• alUSD Feeder Pool Vault 0x0997dDdc038c8A958a3A3d00425C16f8ECa87deb 6
• FEI Feeder Pool Vault 0xD24099Eb4CD604198071958655E4f2D263a5539B 8
• HBTC Feeder Pool Vault 0xF65D53AA6e2E4A5f4F026e73cb3e22C22D75E35C 9
• tBTCv2 Feeder Pool Vault 0x97e2a2f97a2e9a4cfb462a49ab7c8d205abb9ed9 10
• Visor Finance 0xceF5df9d514bF0619c2ee87e2dDF1Af93FfAc0F6 16

The UI does not reflect this, it does not prevent the user to vote for a disabled dial.

1. Show disabled dials in the UI, e.g.:
   

But replace with disabled, make it optionally gray out.

2. Prevent a user to allocate votes for the dial:

• Disable the slider and set it to 0%
  
  %
• Should work for someone that just votes for the first time, or if you had previously votes allocated to the dial

3. Display a warning on the top to vote again, if the user has allocated votes towards the disabled dials
   

• A warning box with the message.

Is your feature request related to a problem? Please describe.
Move deprecated pool either to the bottom or a new tab?

Describe the solution you'd like
The deprecated pool should be not at the top of the page. The easiest solution is just to move the pool to the bottom.

Additional context

Describe the bug
Some data gets mixed up in the app, subgraph requests a blocknumber that is much higher than what is possible on Ethereum. Might be the wrong number from polygon.

To Reproduce
Steps to reproduce the behaviour:

1. Go to https://mstable.app/#/musd/stats
2. Select Mainnet
3. Click on the top graph on 90 Days
4. See error as per screenshot

Expected behavior
Should fetch from subgraph the correct blocknumber with the data

Screenshots

Desktop (please complete the following information):

• OS: MAC/WIN
• Browser Chrome/Brave

Additional context
This error happens in various places, but this is the most reproducible example.

Describe the bug
The mStable.app experiences degraded uptime. Reported by the community was the following screenshot:

Sometimes the page fails to load, sometimes some files get loaded while others fail.

Describe the bug
Icons in the footer appear to be different in size.

To Reproduce
Look at the footer

Expected behavior
Should have more consistent size.

Screenshots

Is your feature request related to a problem? Please describe.
A common pattern in UIs that offer swaps from one asset to the other is that the arrow in the middle can act as a button that can swap the assets. Should be able to click and reserves the order.

In Save Page

1. Go from deposit to redeem and vice versa
   

In Swap Page

1. Arrow should reverse the assets, example screenshot: sUSD -> USDC, reverse to USDC to sUSD.
   

Describe the bug
The staking app throws an error when loading.

Normal App subgraph error, doesn't show Feeder Pools anymore.

To Reproduce
Steps to reproduce the behavior:

1. Go to https://staking.mstable.app/
2. See Error
   
   

Expected behavior
The Feeder Pool subgraph is not really used for the Staking app, should not throw the error or use the FeederPool subgraph.

The Subgraph should be use for the Feeder Pool in the main app/

A bug was discovered in the package BN.js that is used in the ethers.js package.

ethers-io/ethers.js#3017

This might have an effect on rare occasions, we should upgrade to the latest version.

Describe the bug
RAI Feeder Pool shows negative APY

To Reproduce
Steps to reproduce the behavior:

1. Go to https://mstable.app/#/musd/pools/0x36f944b7312eac89381bd78326df9c84691d8a5b
2. See negative APY

Expected behavior
Easy fix: if the APY calculation returns a value below 0% set to 0%. Not worth fixing the underlying problem.

Describe the bug
The Gas estimation always returns 30 for standard, Fast, and Instant. Despite actually gas being higher. Maybe the gas API doesn't return proper values?

Also: standard < Fast < Instant.

Describe the bug
The button "Stake" is clickable despite needing ERC-20 Approval first.

To Reproduce
Steps to reproduce the behavior:

1. Go to https://staking.mstable.app/#/stake
2. Click on staking MTA or mBPT
3. Enter the amount in stake App
4. Lock appears, and is enabled, but "Stake" button is also clickable

Expected behavior
Throwing the error is expected if there is a missing approval. However, the Stake button should not be activated until such approval has gone through.
This results in users missing the approval button.

1. Simple solution: deactivate the button until the approval is done. Replace text with "Allow the Staking contract to use your MTA" or "Allow the Staking contract to use your mBPT"
2. Probably better solution: Add button above staking to create tx for approval.

See Uniswap example:

Screenshots

Trying to send transactions without approval throws an error.

Describe the bug
On Polygon, after any transaction, the balance does not update (or it takes a really long time to do so).

• Ideally, after the transactions, it should reflect the change in balances.
• When the app is open and the balance changes based on some other application, it should also update the balance (e.g. I received some mUSD while I had the App already loaded.)

About

When redeeming LPtokens from a pool that is low in balance or if the withdrawer is the majority holder of the LPtokens, the normal single sided withdrawal does not work anymore. The user needs to withdraw proportionally.

Issue

Feeder Pool page: https://mstable.app/#/musd/pools/0x4eaa01974b6594c0ee62ffd7fee56cf11e6af936

Cannot specify how many pooltokens should be used.

Steps

• Allow redemption based on Pooltokens, e.g. click on the amount to specify or allow amount to be entered in that field.
• Calculate the proportional output.
• Use redeemProportionality (https://etherscan.io/token/0x4eaa01974b6594c0ee62ffd7fee56cf11e6af936?a=0xa23F54e0BB57a6114D831c080823F5Fe2616CF98#writeProxyContract#F13)

https://dashboard.tenderly.co/dimsome/project/simulator/74b3cc5e-baae-407b-b2ad-f3e351f3be18

Describe the bug
The staking App goes blank when the wallet is connected and dials is clicked

To Reproduce
Steps to reproduce the behavior:

1. Go to https://staking.mstable.org/#/
2. Connect Connect Wallet
3. Click Dials in Menu
4. Page goes blank

Expected behaviour
Should navigate normally to dials and show content

Screenshots

Desktop (please complete the following information):

• OS: MacOS and Windows tested
• Browser Edge
• Version 101.0.1210.39 (Official build) (x86_64)

Additional context
Add any other context about the problem here.

Describe the bug
On the staking page https://staking.mstable.app/#/stake the MerkleDrop subgraph is queried, however a error is returned Type Query has no field accounts

To Reproduce
Steps to reproduce the behavior:

1. Go to https://staking.mstable.app/#/stake
2. Connect Wallet
3. Subgraph error
4. Click on Verify claim, to see a further error

Expected behavior
No Error

Describe the bug
Screen to accept T&C is unscrollable. Problematic on smaller screens

To Reproduce
Steps to reproduce the behavior:

1. Go to https://staking.mstable.app/#/stake
2. Stake for the first time
3. See window popup that is quite long

Expected behavior
Add a scrollable area

Screenshots

Is your feature request related to a problem? Please describe.
Currently, we have no process when it comes to adding new delegates or adjusting the profiles (Bio, profile picture). For the future to remain decentralised and to support delegation by known individuals we should have a way to add new profiles and adjust existing ones.

Describe the solution you'd like
A dedicated UI would be probably to cumbersome, but I would imagine a repo where individuals can add themselves into a JSON file that we then can use to upload periodically when required.