Code Monkey home page Code Monkey logo

Comments (3)

TheArrowsmith avatar TheArrowsmith commented on July 20, 2024 2

I know this thread is very old, but I was just struggling with this same issue, so for the record: I solved this by putting plug CORSPlug in endpoint.ex as described here.

from cors_plug.

Gyllsdorff avatar Gyllsdorff commented on July 20, 2024

From http://hexdocs.pm/phoenix/Phoenix.Router.html
Note that router pipelines are only invoked after a route is found. No plug is invoked in case no matches were found.

You can "solve" this by adding a dummy OPTIONS handler in router.ex

defmodule Uploader.Router do
  use Uploader.Web, :router

  pipeline :api do
    plug :accepts, ["json"]
    plug CORSPlug
  end

  scope "/upload", Uploader do
    pipe_through :api

    post "/", UploadsController, :create
    options "/", UploadsController, :nothing
  end
end

from cors_plug.

ravinggenius avatar ravinggenius commented on July 20, 2024

Thanks for pointing me to the docs; I had no idea the router wouldn't trigger the pipeline unless the whole route matched. Since we only need CORS on a single endpoint, we skipped the plug and added a regular action to the controller.

Where does :nothing come from? Would I also have to define that in my controller for it to work, or is it special?

from cors_plug.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.