Code Monkey home page Code Monkey logo

Comments (3)

CrowdHailer avatar CrowdHailer commented on July 20, 2024 1

Ahh yes I see. Same check as is found here

cors_plug/lib/cors_plug.ex

Line 74 in 1ca97ed

defp cors_headers(nil, _options) do

Could you add a test case that fails because of how it is currently set up. Then we can work out the best way to fix it

from cors_plug.

CrowdHailer avatar CrowdHailer commented on July 20, 2024

Doesn't the line below the one you linked to recall the headers function but with method set to nil so that it goes on to check the requests origin here.

cors_plug/lib/cors_plug.ex

Line 54 in 5dfdbb7

headers(%{conn | method: nil}, options) ++

then

cors_plug/lib/cors_plug.ex

Line 64 in 5dfdbb7

allowed_origin = origin(options[:origin], conn)

from cors_plug.

slashmili avatar slashmili commented on July 20, 2024

What I mean is in here

cors_plug/lib/cors_plug.ex

Lines 56 to 63 in 1ca97ed

defp headers(conn = %Plug.Conn{method: "OPTIONS"}, options) do
headers(%{conn | method: nil}, options) ++
[
{"access-control-max-age", "#{options[:max_age]}"},
{"access-control-allow-headers", allowed_headers(options[:headers], conn)},
{"access-control-allow-methods", options[:methods]}
]
end

we always set access-control-* headers regardless of the origin is set in configuration or not

from cors_plug.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.