Origins config is being pre-compiled about cors_plug HOT 4 CLOSED

I just published 1.5.0 with you changes (and some cleanup). Thanks!

https://hex.pm/packages/cors_plug/1.5.0

from cors_plug.

Hey,

Thanks for your issue description, it’s very thorough and it all makes sense to me.

I’m ok allowing a function for origin that is called on every request. May I ask how you configure the app? If it is through environment variables we could discuss passing a {:system, “VAR_NAME”} tuple or something of the like. That’s how I’ve seen other libraries handle this issue.

Either way I can give you a branch to test in the next few days unless you want to submit a PR.

Thanks,
Michael

from cors_plug.

I'm using docker secrets, so the config is inside a specific file in my filesystem (something like /run/secrts/origin. I'm also using memoize (https://github.com/melpon/memoize) to avoid reading the same file over and over again after every request.

from cors_plug.

When you publish a new version, can you let me know? Thanks!

from cors_plug.