Handling run-time configuration about cors_plug HOT 3 CLOSED

Doteki looks awesome but I think including another lib into this is overkill, sorry.

The {:system, value} approach would be ok for me but it does add overhead. I'll do a little benchmarking, given how fast Elixir does functions I'm pretty confident it will be negligible.

I still like the function-based approach: That function is only called once rather than on every call to plug. This has the benefit that when using ENV variables, we only do an ETS lookup (wich is comparably expensive) only once rather than with every call to plug.

I'm very performance-conscious because plugs have to be as fast as they possibly can. Hope that makes sense.

from cors_plug.

Hello,
The {:system, "VALUE"} workaround has the advantage of being simple and wide spread. Moreover, some projects, such as https://github.com/botsunit/doteki greatly enhance it (handling of other types than binaries (integers, atoms, lists), ability to use functions as variables...)

from cors_plug.

No problem !
Completely agree with the critical importance of plugs' performances.
Corsica makes use of functions too, to handle dynamic allowed origins...

from cors_plug.