Adding new headers overrides default ones about cors_plug HOT 4 CLOSED

@hojgr Thanks for your kind words.

As for the behaviour you are seeing - that's expected and by design. Defaults are defaults, by providing your own values overrides the defaults. This is standard in every package I've seen.

My reasoning is that you might want only allow a subset of the default headers. Maybe you explicitly don't want to allow Content-Type headers. Furthermore I like the "explicitness" of this solution. I am using it myself.

The only thing I could think of is to provide a key similar to additional_headers:. But I don't believe that would be very intuitive.

So while this might be a small consolation, maybe it's a tad nicer if you left out the parens:

plug CORSPlug, [
  origin: "http://localhost:4200", 
  headers: ["X-Auth-Token" | CORSPlug.defaults[:headers]]
  ]

Any further feedback and ideas are very welcome!

from cors_plug.

Thanks for answers. The explicitness is indeed nice and I did not think about the use case where not having defaults is required.

Thanks.

from cors_plug.

Glad I could help.

Thanks again for your feedback and please let me know if there is anything I can improve on.

Cheers

from cors_plug.

It doesn't work
https://stackoverflow.com/questions/36713069/elixir-phoenix-how-to-use-third-party-modules-in-config-files

from cors_plug.