mrsegev / movienight Goto Github PK
View Code? Open in Web Editor NEWMovieNight is a sample Android application that uses the clean architecture approach and is written in Kotlin.
movienight's People
Contributors
Stargazers
Watchers
Forkers
winterdl matrixy tsok-xyz selmanon pahlevikun kodeartisan lobothijau thepoosh oatrice aleksandar-kojic ninjayoto benju69 utsavstha aleksandarkojic repoforks up1 wassimz bayupaoh gedu nelsitopuglisi morristech priestd09 libbliy hoangpq jenus vinceshenglong visualrainy rodolf0s dimrix sunwicked f8full ananddamodaran anand-1901 orionthewake sudr apdallah sergiiz vivekprcs simplyjaymin fabiancarlos polivmi1 edu1345dev dtuan yaroslav-shlapak arundeep27 cheloreyes resutoor onyxmueller dcn01 soulyaroslav way2jatin irfanirawansukirman tamanneupane apmadden codecameo uburoiubu hubertswiecioch icrona raymondzhaoy yoyocoder yajra bmachimbira mizzang frozair toantran-ea mohammedgmgn puitiza swapnilbagadia trendingtechnology damdamgo alvaromarco husseinbl90 dreamx3012 smilecs noguespi abdelmoughitrabia morphiumdeus fdbshh filiphristovski hbrtose nicopasso sagardep jflavio11 nyinyihtunlwin-codigo alonaviram vuthanhvt08101991 mekanzoo shakil807g purplecipher hatem-tmi manishgithub1173 mazing27 shiveshmehta09 prathanbomb developer-tahir-saleem ko-htut filosofisto trietbui85 mozay walkmansitmovienight's Issues
Why are there 2 classes that are exactly the same
This is a question, not an issue. I'm curious, why are there 2 classes that have exactly the same signature: MoviesRepository and MoviesDataStore here: https://github.com/mrsegev/MovieNight/tree/master/domain/src/main/kotlin/com/yossisegev/domain
Is this a standard approach by duplicating the class? I imagine if you had a very large project with lots of models and methods it would become a bit confusing..
Room cache bug accessing on main thread when switching caching mechanism
First of all, I wanted to say that your tutorial / blog post was a great and inspiring to me to create more maintainable Android code. So a big thank you!
But you say in your blogpost that you can easily switch between caching mechanisms but when I switch the cache for the movierepository to DI.favoritesCache (Room instead of memory) the app won't launch because of accessing the DB on the mainthread. This happens I think of accessing the cache directly in the MovieRepositoryImpl file with if (!cache.isEmpty())
Do you have any thoughts on this?
And again, thank you for this inspiring post and repo!!
Question: data module > DetailsData & MovieData
What's the difference of DetailsData & MovieData. I know MovieData is used in room as it was annotated, but would there be a difference if you just used MovieData?
UserPrefs Recommendations?
Where would you recommend to put SharedPreferences if it is to be used? I'm actually thinking data.cache. Does that work?
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.