mrozmanith / flexcairngorm Goto Github PK

Thank you very much for your framework. Great work guys!

Here is the issue I faced that might not be related to
an actual framework issue but perhaps a misunderstanding.

1. I create a separate MXML component holding Eventgenerator declaration 
(in attached)
2. I reference the component in the main application view
3. I start the sequence in calling the dispatch method on the referenced 
component

The sequence of events shall be dispatched.
Instead, I get a "Cannot access a property of a null object reference".
I attach the debug screen of FB that points the location of the issue.

Latest source version is used.
When the same code in the external MXML component is put in the
main application MXML the sequence is working.

I'm looking forward to any answer. Thanks.
Cédric

On your home page, you state:

> SubControllers are available so modules implemented with sub-MVC...

However, isn't there still an issue with ServiceLocator and modular
sub-apps? That is, don't you still have to define the Services list (and
only one) at the top level of the application, due to the fact that it is 
Singleton? I'd love to see each Module setting up its own list of Services,
independent of the overall app, but perhaps not a good idea...

If you have a work-around, I'd love to see it, as this the only area I
haven't been able to accomodate, when I'm using Cairngorm these days!

[sorry if not correct location for this issue]

cairngorm 221 version of the store isn't downloadable, promps for a a password

What steps will reproduce the problem?
1. Dispatch a SEQUENCE generator (implicitly or explicitly)

What is the expected output? What do you see instead?

Expect sequence, but the following code at the tail end of dispatchNext()
in EventGenerator breaks after the first event in the sequence is dispatched:

// Only break loop if firing a SINGLE event
if (this.trigger == TRIGGER_SEQUENCE) break;

What version of the product are you using? On what operating system?

svn updated this morning.

Please provide any additional information below.

Judging from the comment on the code up there, I can only guess that you
were thinking of creating a new trigger type of SINGLE .. no? If so, it
would make sense to break on (this.trigger == TRIGGER_SINGLE). As is, it
kills my sequence after the first of two events.

Commenting this out or changing TRIGGER_SEQUENCE to TRIGGER_SINGLE allows
my sequence continue as I expect.

What steps will reproduce the problem?
1. Look at EventGenerator.initialize() code
2. Note that first param - "document" - isn't used by the code

     public function initialized(document:Object, id:String):void {
        this.id = id;
     }

Also, it would be great to get some clarification of how/when/why "id" is
meant to be used. It gets passed out by onAnnounceDone() and
onAnnounceFail(). Clearly the code using the EventGenerator can use this to
check which EventGenerator has failed or finished, which makes sense. But
why can't we pass this id value into the constructor? Why is it called
initialized() rather than initialize()? It looks at though this is a
not-completely-finished bit - and some clarification would be helpful.

But please take this pickiness within context - I love these extensions,
and appreciate the contribution!

Douglas

What steps will reproduce the problem?
1. Open the Delegates class in com.universalmind.cairngorm.business and/or
the asdocs for the class
2. look at the last line of the onResults_doLogin function
3. notifyCallers(new ResultEvent(response)) 

What is the expected output? What do you see instead?
there is no method called notifyCallers() (plural) use notifyCaller() instead

What version of the product are you using? On what operating system?
UM_Cairngorm 2.2.1

Please provide any additional information below.
the example call to notifyCallers() made me think I was not working with
the current version, but now I think this is just a typo.

I have a command titled 'AddUserCommand' which extends
com.universalmind.cairngorm.commands.Command.  If I set a variable in the
command as [Bindable], I get the following error: 

Implementation of interface 'flash.events:IEventDispatcher' cannot be added
to class 'AddUserCommand', due to collision with existing method or
property 'dispatchEvent'.   

I am guessing its not good practice to set a command property as
[Bindable].  However, just thought I would point out the issue.

The version of Cairngorm 2.2.1 that you include is a bit different from the
code available from Adobe.

Adobe's ServiceLocator class has an "instance" prop.

The version you include has "__instance" instead.

Needless to say, this breaks things if a developer already has Adobe's
version in place, and just adds the com.universalmind.cairngorm code, as
UM's ServiceLocator references __instance.

Are there any other differences? Might be a good idea to run a diff and see
if there are any other changes to your version of the com.adobe.cairngorm
code...

(I'm assuming that you're using "normal" Cairngorm - not Cairngorm Enterprise.)

BTW, lest I seem to complain much, I appreciate your releasing this code.
Some good stuff here.  :)

Should this method not return true if it's a ModuleController?

      private function checkModuleType(subController:*):Boolean {
            if (subController is ModuleController) return false;
            else {
                var msg : String = "SubControllers must be subclasses of
ModuleController.";
                throw new Error( msg ); 
            }
      }

regards

I've been using the EventGenerator a little.

Would it be a good id to be able to throttle the parallel series of events?

EG: if I have 10 events I would like to fire off in parallel, but only want
3 to be running at anyone time?
Retrieving data from a web server could be a situation where this would be
helpful.

Pseudo code:
new EventGenerator( eventQue , queHandler ,-1 ,
EventGenerator.TRIGGER_PARALLEL , 3 ).dispatch();

where the last argument of "3" is the number of parallel events to be
running at any one time.

[deleted issue]

What steps will reproduce the problem?
1. Try to checkout from SVN into an empty folder using Tortoise on Vista

What is the expected output? What do you see instead?
I'm getting this error:
Error: Can't copy 'C:\_Data\_CodeLib\Flex\UM
Cairngorm\code\build\.svn\tmp\text-base\UM_Cairngorm_221.swc.svn-base' to
'C:\_Data\_CodeLib\Flex\UM
Cairngorm\code\build\.svn\tmp\UM_Cairngorm_221.swc.tmp.tmp': No error  

I was able to successfully checkout the code a few weeks ago. Tried to
update first, but got a similar error.

Obviously, I can't be sure that this is a problem with the repository, but
I've used Tortoise to checkout lots of stuff from other sources with no
problems. 

What steps will reproduce the problem?
1. Create and dispatch a sequential generator:

new EventGenerator([loginEvent, setUserEvent]).dispatch();

What is the expected output? What do you see instead?

Expected both events to be dispatched, but only the first was

What version of the product are you using? On what operating system?

revision 76 of EventGenerator.as

Please provide any additional information below.

getNext() returns the next event per __sequence[__doneCounter]. However,
__doneCounter is not incremented until onEventDone or onEventFail, which
don't necessarily happened before the while(hasNext() == true) loop comes
around to dispatch the next event - so the subsequent event is not
dispatched, because __doneCounter is still 0 rather than 1. 

I fixed this by creating a new variable __dispatchedCounter which is
incremented in markAsDispatched() and altering getNext() to look at
__dispatchedCounter instead of __doneCounter. File with changes is attached!

Thanks for the UM extensions!

What steps will reproduce the problem?
1. Create a FrontController
2. Try and add a ModuleController as a sub-controller; doesn't get added.


What is the expected output? What do you see instead?
ModuleController's commands should get added to the main controller.

What version of the product are you using? On what operating system?


Please provide any additional information below.
FrontController line 122 -- checks to see if the module is a
ModuleController, and if it is, it returns *false* -- meaning it never gets
added to the Front controller. Should probably return true.

What steps will reproduce the problem?
1. use addSubController() to inject event/command mapping of a
ModuleController instance
2. event/command mapping inside of FrontController gets corrupted
3.

What is the expected output? What do you see instead?
mapping should work

What version of the product are you using? On what operating system?
latest as of filing this issue

Please provide any additional information below.

Inside ModuleController there is an implicit getter for registredEvents
which ahould return an array in the manner of: EventKey -> CommandReference.

However, using a for each loop, the object's mapping will be: [Command
Object] -> null.

TODO: replace 'for each' with 'for'

I could not find a way to post questions. All the email addresses are like
username...@domain.

Thanks
Faisal

Hi Folks,

It looks as if you've neglected to change the copyright notices on at least
some UMCairngorm classes. I haven't done a thorough inventory, but
BaseController and FrontController still have UM's proprietary license.

Could you zip me an email assuring me that you really are open-sourcing
this code?

BTW, looks very interesting!

Thanks,

Douglas McCarroll
Brightworks

If you call "notifyCaller()" with no value, the handler will receive an
argument.

consider:

public function bob() : void
{
var handler : CallBacks = new Callbacks( onResult_bob );
var event : MyEvent = new MyEvent( MyEvent.EVENT , handler ).dispatch();
}

--the notify caller from the command is just:
notifyCaller();

--if the handler is:
onResult_bob() : void {}
--an error is thrown as an argument is passed
--if the handler is:
onResult_bob( result : * ) : void {}
-- no error is thrown, but the value of "result" is null

Let me know if you need more info from me

Cheers,

David Harris
[email protected]