mrdagree / els-fivem Goto Github PK

Bug Description

After Adding "forced patterns" in the VCF, and updating the file, they don't work

Reproductive Steps

Change forced patterns options in VCF, upload, and restart

Expected Behavior

The stage change should change the pattern

ELS Information

• Version #: 1.92
• Server Version #1.0.0.2083:

Failed to execute thread: server/server.lua:678: attempt to get length of a nil value (global 'vcf_files')

AddEventHandler('onResourceStart', function(name)
	if name:lower() == GetCurrentResourceName():lower() then
		patternInfoTable.primarys = {}
		patternInfoTable.secondarys = {}
		patternInfoTable.advisors = {}
	    for i=1,#vcf_files do
	    	local data = LoadResourceFile(GetCurrentResourceName(), "vcf/" .. vcf_files[i])

		    if data then
		        parseObjSet(data, vcf_files[i])
		    end
	    end

Describe the bug
When the vehicle is being damaged without the sirens and engine breaks down, it cannot go anymore until a mechanic comes and repair it. However, when the lights are turned on, the engine is like brand new.

To Reproduce
Same as the description. Turn them off, crash until the engine breaks down and turn the lights on -> brand new engine until the lights are on and car can still go.

Expected behavior
Brand new engine on lights on every single time the engine breaks down.

Screenshots
If applicable, add screenshots to help explain your problem.

ELS Information:
Version #: 1.75
Server Version #: 6.2.2
Screenshots of Config.lua, vcf.lua, vcf folder:

Haven't changed anything to any of the files.

Additional context
Add any other context about the problem here.

Describe the bug
A clear and concise description of what the bug is.

To Reproduce
Steps to reproduce the behavior:

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.

ELS Information:
Version #:
Server Version #:
Screenshots of Config.lua, vcf.lua, vcf folder:

Additional context
Add any other context about the problem here.

Bug Description

When adding any ELS car to FiveM, the lightbars just seem to flicker there pattern, as opposed to properly displaying there pattern

Reproductive Steps

Spawn in an ELS car and use the lights

Expected Behavior

Lightbars to produce the normal pattern for the XML file, rather than just flicker randomly

Screenshots

N/A

ELS Information

• Version #:1.9
• Server Version #: FXServer-master v1.0.0.1972 linux
• Screenshots of config.lua, vcf.lua, vcf folder:

VCF Folder

vcf.lua

Config.lua

Additional Information

Bug Description

I noticed that there is an error in the script!
All cars added to the ELS system when they crash they fix automatically!
But this only when someone is inside the vehicle along with the motorcycle!
So if you have 2 people in the car, and the driver crashes it, the car for the passenger is fixed automatically!
For the driver he does not agree on how long he is in the car, after he gets out and the person who was in the car along with him gets in, the car for the driver automatically fixes!
I did all these tests all day, removed several scripts and in the end this error was from ELS!
I tried using old versions but it didn't solve ...
I'm leaving my ELS configuration files from both an old version (It's in the folder like: ELS-Fivem) and the new version (It's in the folder like: ELS-FiveM-new-old)

Reproductive Steps

Expected Behavior

Screenshots

ELS Information

• Version: 1.8 and 1.9
• Server Version: 1972
• Screenshots of config.lua, vcf.lua, vcf folder:
  https://uploads.richardsondouglas.com.br/mstsc_XMaFQxM9m2.png
  https://uploads.richardsondouglas.com.br/mstsc_AaClLUW0y7.png
  https://uploads.richardsondouglas.com.br/mstsc_eBnEkwvsgK.png

Additional Information

https://uploads.richardsondouglas.com.br/ELS-FiveM.zip

after spawning a police car and drive in it.
the weapon wheel is not working.

Describe the bug
ELS stops functioning after a short while, constant calls to inVehicleELS = true & canControlELS = true so appears the client.lua is constantly being called. Also notice the panel disappears but hotkeys still work, then ELS fails altogether. Side bug seems to be the weapon wheel (TAB) remains disabled when exiting vehicles.

To Reproduce
Steps to reproduce the behavior: Changing ELS capable vehicles quickly breaks ELS, although the issue does no resolve if waiting a time before re-entering. The bug happens as soon as you enter an ELS vehicle.

Expected behavior
ELS to function normally when swapping vehicles, weapon wheel to work on exit.

Screenshots
F8 Screenshot:

ELS Information:
Version #: 1.75 with latest commit e6ac911
Server Version #: Artifact 1184
Screenshots of Config.lua, vcf.lua, vcf folder:

Additional context
Issue only occured after we updated to the latest commit, beforehand we were getting a lot of instancing when using ELS vehicles close to eachother.

Describe the bug
I have ELS installed on my server. Occasionally my players will complain that ELS has suddenly stopped working. On each car all of the lights suddenly go dark and stop working, except for the flashing headlights or taillights. This seems to be client side as it will not happen for all clients at the same time. A game restart and occasionally a FiveM client cache clear is required to fix the problem.

To Reproduce
It is completely random.

ELS Information:
Version #: 1.75
Server Version #: 9.5.8
Screenshots of Config.lua, vcf.lua, vcf folder:
https://gyazo.com/35f194b32d066c92196d8f50d9560f67
https://gyazo.com/6fd47129388bb2ec599b44de634a3728

As the title says, when the emergency vehicle is on light stage 3, it'll never stop working, is anyone with the same issue?

Bug Description

When i spawn car-everything is okay and not blikning. When i change modes 4 times (pressing Q) and then i want to stop light bar- it stops but my backlights are always blinking. I cant stop them anyway... they are always blinking but with different patterns. Only when i spawn car- they are turned off. Siren is same.

Reproductive Steps

1. Spawn car
2. Press 4 times Q
3. Back lights are always blinking

Expected Behavior

Not blinking- set in neutral position. Its kind of out of sync.

Screenshots

Video-https://youtu.be/dGf6Jr-Rpvk

ELS Information

• Version #: 1.92
• Server Version #: v1.0.0.2345 win32
• Screenshots of config.lua, vcf.lua, vcf folder:
  https://i.imgur.com/sA3027t.png
  https://i.imgur.com/mONS5gt.png
  https://i.imgur.com/Av7jNaw.png

Hi, after renewing my server with newer artifacts (otherwise no change for ELS, which has been working fine till now), I can't turn of siren lights completely. There are always at the first setup of the chosen lighting pattern. Never fully turned off. V 1.1.3a

Error resuming coroutine: @ELS-FiveM/client/client.lua:412: attempt to index a nil value (field '?')
stack traceback:
@ELS-FiveM/client/client.lua:412: in function 'setExtraState'
@ELS-FiveM/client/client.lua:1659: in function <@ELS-FiveM/client/client.lua:1650>
Error resuming coroutine: @ELS-FiveM/client/client.lua:412: attempt to index a nil value (field '?')
stack traceback:
@ELS-FiveM/client/client.lua:412: in function 'setExtraState'
@ELS-FiveM/client/client.lua:1618: in function <@ELS-FiveM/client/client.lua:1611>

Stuck at this static light setup, when it should be off.

When i have the ELS script on my server the headlights on the cars with ELS just keeps blinking like if the emergency lights was on, but they are not. When I turn it off it sould not still be blinking

Describe the bug:
Cruise lights are not working even though the panel shows they're activated. Everything else works great.

Steps to reproduce the behavior:
I am able to reproduce this with all ELS enabled vehicles by pressing the CRS button.

Expected behavior:
When I press the CRS (Cruise Light Button), I expect the cruise lights enabled in the els XML to turn on.

Screenshots:

ELS Information:
Version #: 1.75
Server Version #: v1.0.0.1096 win32

Screenshots of Config.lua, vcf.lua, vcf folder:

Hello

unfortunately, other passengers in the car can also control the lamps. Is it possible to enter a setting in the configuration that only the driver of the vehicle can control the lamps?

In patterns.lua you've used (mostly) 4 tab indents but the rest is 4 space indent? Why? P.S I'd recommend 4 tab indents

Bug Description

when you turn on the lights the lightbar/every extras despawn and spawn when you have the lights on

Reproductive Steps

every time i turn on the lights they do it

Expected Behavior

they despawn

Screenshots

https://cdn.discordapp.com/attachments/541622280753643522/700043223938105534/light.PNG
https://cdn.discordapp.com/attachments/541622280753643522/700043239096320060/light3.PNG
https://cdn.discordapp.com/attachments/541622280753643522/700043245136379976/light2.PNG

ELS Information

• Version #: try every
• Server Version #: https://cdn.discordapp.com/attachments/541622280753643522/700044773125521520/hallo.PNG
• Screenshots of config.lua, vcf.lua, vcf folder: https://cdn.discordapp.com/attachments/541622280753643522/700043998458413136/vcf2.PNG
  https://cdn.discordapp.com/attachments/541622280753643522/700043996113666066/vcf.PNG

Additional Information

Hello,

When i instal ELS on an ADDON police car or lets say emergency car the AI traffic wont get out of the way like they do for an replace police car

I hope u can help me

The new build is looking great. I love the new hud. Anyway not sure if you are aware, but turning on the stages of the sirens cause the lights / other parts of the car to flash. For instance on the police2 the lightbar with go invisible all together. On the police3 a spoiler will appear and disappear even though it has no spoiler by default. This continues across several models.

Hope you get it worked out and thanks for the new dev updates!

How can I change the Location of the ELS GUI? I would like to set the GUI at the top on the right

Bug Description

One of these variables is nil in line 606, causing the thread to break.
MainThrd/ ^1SCRIPT ERROR: @els3/client/client.lua:606: attempt to index a nil value (field '?')^7

Reproductive Steps

Use ELS consistently in a high pop server for > 15mins

Expected Behavior

Not for thread to break so ELS continues working

Screenshots

N/A

ELS Information

Latest

Describe the bug
When i have the ELS script on my server the headlights on the cars with ELS just keeps blinking like if the emergency lights was on, but they are not.

To Reproduce
Steps to reproduce the behavior:

Expected behavior
When I turn it off it should not still blink

Screenshots
If applicable, add screenshots to help explain your problem.

ELS Information:
Version #: 1.75
Server Version #:
Screenshots of Config.lua, vcf.lua, vcf folder:

Additional context
Add any other context about the problem here.

Error running system event handling function for resource ELS-FiveM: citizen:/sc ripting/lua/scheduler.lua:41: Failed to execute thread: server/server.lua:15: at tempt to concatenate a nil value (upvalue 'NewestVersion')

Describe the bug
Today we changed our server to 64 slots version, with onesync, it always worked fine since today when we changed the version. Now the menu works and it changes the lights with Q keys but the lights doesn't turn on.

To Reproduce
I get into the car, the ELS menu appears, i click Q key to switch to light pattern, the siren buttons switch and turns on but anything more happends, the lights never turns on.

Expected behavior
When I click the Q key the lights should turn on.

ELS Information:
Version #: 1.75
Server Version #: FiveM/OneSync-ALPHA
Screenshots of Config.lua, vcf.lua, vcf folder:

Hey,
i've been looking for this part but couldn't find it anywhere but how do i change what sirens play per vehicle. As i see it now ELS is configured to always play the police sirens except for siren3 (the warning siren in the els menu). Can this be changed because changing this in the XML files doesn't work.

For example once i have an ambulance and choose siren option 1 or 2 it plays police sirens instead of ambulance sirens. The same thing happens with a firetruk.

I just want police vehicles to play police sirens, police bikes police bike sirens, firetrucks firetruck sirens, ambulance ambulance sirens (u know where im going to......)

Again does someone know a fix for that or does it still need to be implemented and if so, how can this be done???

Thanks in advance,
-subtraho

So basically i put my addon car to my server. I want that addon to have els lights but no siren sounds.

so i did this.

<SOUNDS> <MainHorn InterruptsSiren="true" AudioString="SIRENS_AIRHORN" /> <ManTone1 AllowUse="true" AudioString="" /> <ManTone2 AllowUse="true" AudioString="" /> <SrnTone1 AllowUse="true" AudioString="" /> <SrnTone2 AllowUse="true" AudioString="" /> <SrnTone3 AllowUse="true" AudioString="" /> <SrnTone4 AllowUse="true" AudioString="" /> <AuxSiren AllowUse="true" AudioString="" /> <PanicMde AllowUse="true" AudioString="" /> </SOUNDS>

i dont hear it (thats perfect!!!) but everyone else can.

how can i mute that siren for others but not for only me!!

is that bug??

Describe the bug
When entered into a single session, or purposefully leave the session for rockstar editor, ELS will randomly turn on lights and sirens as if someone else is controlling it.

To Reproduce
Single session whilst other people are in a normal session. Use ELS.

Expected behavior
No difference to usual use.

ELS Information:
Version #: 1.75 (latest)
Server Version #: latest
Screenshots of Config.lua, vcf.lua, vcf folder: N/A (no additional files or edits)

Additional context
Add any other context about the problem here.

They are not accurate, i don't even know what key code table are you using for...
If you could help me please, thx

build = "master"

shared = {
	horn = 86,
}

keyboard = {
	modifyKey = 132,
	stageChange = 85,
	guiKey = 199,
	takedown = 83,
	siren = {
		tone_one = 157,
		tone_two = 158,
		tone_three = 160,
	},
	pattern = {
		primary = 163,
		secondary = 162,
		advisor = 161,
	},
	warning = 246,
	secondary = 303,
	primary = 7,
}

Describe the bug
A clear and concise description of what the bug is.
My els is "stopping" so the els menu goes away and sirens no longer work, if they were turned on they get stuck.
To Reproduce
Steps to reproduce the behavior:
Just having 30+ players on server and it "crashes"
Expected behavior
A clear and concise description of what you expected to happen.
i expect it to work
Screenshots
If applicable, add screenshots to help explain your problem.

ELS Information:
Version #:1.9
Server Version #: 1903
Screenshots of Config.lua, vcf.lua, vcf folder:

Additional context

Describe the bug
Random FPS Drops. So essentialy, my graphics card is GTX 970 and ELS works perfectly fine for me on our FiveM server. But then for some reason, other people with graphic cards GTX 1080 ti and stuff like that experience up to 50FPS drop when the sirens are turned on. The more vehicles with sirens that there are the more FPS drop will happen. We all have same/similar seetings for GTA V (Everything to max) so I don't understand why this is happening

To Reproduce
I don't think that every single person can reproduce this, but if you wish to try, all you have to do is spawn one or more ELS vehicles and turn on the sirens. The more you spawn the bigger FPS drop.

Expected behavior
I hope that someone will be able to help me and make the FPS drop thing dissaper. Cause we really want to use ELS, but we just can't afford it if many players will get max 15 FPS around emergency vehicles.

Screenshots
Sadly I don't have screenshots, as this thing doesn't happen to me, but there is nothing much to see. It's a common FPS drop, so everything just becomes really laggy.

ELS Information:
Version 1.1.3a & 1.75 (tested on both and same results):
Server Version Linux build: 1052-5263e3d13eacecd18cdf7541fe04458b12bbdfd
Screenshots of Config.lua, vcf.lua, vcf folder:

I currently don't have access to vcf.lua, since we decided to try the latest stable release, which is 1.1.3a and this one doesn't have vcf.lua file

Additional context
Like I said, the problem doesn't seem to be quality of graphics card, etc. Since it works perfectly fine for my GTX 970 while it's destryoing my friend's FPS on his GTX 1080 ti. GTA V graphics settings are the same or very similar.

At times you will be come stuck at it looks like stage 2 lighting, lights will still turn on through the stages but when you shut off all lights it still shows some lights on and static not flashing...Found this

right before the lights broke

---------- ELS (master Build) by MrDaGree ----------
Current Version: 1.1.3a
Newest Version: 1.1.3a

---------- Outdated ----------

CHANGES:

• Github change

  Whats the point of putting something funny
  if its not even funny?

Hi,

Linux is CaseSensitive for file then when ELS try to load .xml with vcf.lua file, he can't find police2.xml etc because in the vcf.lua he is write : POLICE2.xml

I don't know if u are french but ...
Salut,

Linux est sensible à la case, du coup quand ELS fait appelle à vcf.lua, il essaye de charger POLICE2.xml alors qu'il s'appelle police2.xml.

The manifest version is missing

Describe the bug
A clear and concise description of what the bug is.
The first issue is that the lighting panel flashes anytime signal 1 - 3 are active

The second issue is that when toggling the lights off the remain on for what seems to be a random amount of time, sometimes briefly sometimes longer.
To Reproduce
Steps to reproduce the behavior:
Issue 1: Toggle any signal 1-3 on and have control panel visible

Issue 2: Toggle through signals within an els vehicle
Expected behavior
A clear and concise description of what you expected to happen.
Issue 1: While signals are active or inactive and panel is enabled I expected the panel to remain statically visible

Issue 2: Expected lights to cease when toggled off
Screenshots
If applicable, add screenshots to help explain your problem.

ELS Information:
Version #:1.75
Server Version #: 1380-0b3915618c6cc278c2457ea93775255ed41e49c3
Screenshots of Config.lua, vcf.lua, vcf folder:
VCF Folder: https://gyazo.com/32375032ee6cfdda044361dc388d00fe
vcf.lua: https://gyazo.com/c08be699c34d3d591542d0f1ec5bb1be
Config.lua: https://gyazo.com/efc7932b0436243b8c2d0be896845cae

Additional context
Add any other context about the problem here.
I have ran this script since April of 2019 with no issues, these issues recently appeared after a long list of FiveM client and server updates. I appreciate any help in resolving this issue. If a video of the actions would be helpful I will gladly comply.

Thank you for your time and please have a wonderful day,

Rich Biggs
Discord info for further contact if necessary: Rich Biggs#6564

I have done exactly as the video showed but ELS is not working.

Debugging return an impossible concatenation at line 814

https://imgur.com/a/oPUH7Pv

i tried to edit your code to remove useless buttons for our server.
We only want to keep 1,2,3 sirens and Q on panel?
is there any way you can edit it and send it to me?

Bug Description

I've replaced a lot of government vehicles. Most of them have ELS (a .xml file). All well installed. But it's just a texture that changes color. Not really a flashing light. During the day (in game) you see almost nothing.

Reproductive Steps

You can't reproduce it by see. It's always the case.

Expected Behavior

I want the lights to be like real lights. Not just a texture that changes color.

Screenshots

My cars:

• https://streamable.com/96mh5
• https://streamable.com/j6177
• https://streamable.com/yvnam
• https://streamable.com/uh7fi
• https://streamable.com/y2vlt
• https://streamable.com/p66xe
• https://streamable.com/rx4yc

Examples of how we want it:

• https://imgur.com/a/zTitvNH
• https://streamable.com/7qzrh
• https://streamable.com/itgys

ELS Information

• Version #: 1.92
• Server Version #: FXServer-master v1.0.0.1971 linux

• config.lua, vcf.lua and vcf folder: https://imgur.com/a/dLgzEVI
• All .xml files inside: https://streamable.com/snbt0

Additional Information

It's probably due to our ELS resource, because other servers have exactly the same cars with much better lights.

Describe the bug
A clear and concise description of what the bug is.

To Reproduce
Steps to reproduce the behavior:

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.

ELS Information:
Version #:
Server Version #:
Screenshots of Config.lua, vcf.lua, vcf folder:

Additional context
Add any other context about the problem here.

Error: Script Error: @els/client/client.lua:431: attempt to index a bollean value.
Any idea why I am getting this?

when i spawn the sheriff no light control and the radio comes on

The error in my console if i use ELS vehicle:

ELS ERROR FROM CLIENT
PLAYER NAME: Raoul
PLAYER ID: 2
ERROR: SCRIPT ERROR: @ELS-FiveM/client/client.lua:431: attempt to index a boolean value

Bug Description

I've replaced a lot of government vehicles. Most of them have ELS (a .xml file). All well installed. But it's just a texture that changes color. Not really a flashing light. During the day (in game) you see almost nothing.

Reproductive Steps

You can't reproduce it by see. It's always the case.

Expected Behavior

I want the lights to be like real lights. Not just a texture that changes color.

Clips

My cars:

• https://streamable.com/96mh5
• https://streamable.com/j6177
• https://streamable.com/yvnam
• https://streamable.com/uh7fi
• https://streamable.com/y2vlt
• https://streamable.com/p66xe
• https://streamable.com/rx4yc

Examples of how we want it:

• https://imgur.com/a/zTitvNH
• https://streamable.com/7qzrh
• https://streamable.com/itgys

ELS Information

• Version #: 1.92
• Server Version #: FXServer-master v1.0.0.1971 linux
• config.lua, vcf.lua and vcf folder: https://imgur.com/a/dLgzEVI
• All .xml files inside: https://streamable.com/snbt0

Additional Information

It's probably due to our ELS resource, because other servers have exactly the same cars with much better lights.

(reupload because you didn't anwser my case.)

Unused variables: https://github.com/MrDaGree/ELS-FiveM/blob/master/client/client.lua#L6

fps = 0
prevframes = 0
curframes = 0
prevtime = 0
curtime = 0

This is for V1.1.3a
Just migrated my server from Windows to Linux, after doing the necessary modifications to the config file so Linux can reference xml file names, I am having an issue when the car is at stage 1 of lights and stage 3.

At stage 1 the rear brake lights that would be flashing but no other lights, at stage 2 everything is functioning normally, however at stage 3 all lights are flashing except for the rear brake lights.

Detailed in these gifs:

Stage 1: https://puu.sh/Bfzrj/6149962fe7.gif
Stage 2: https://puu.sh/Bfzvp/78a0563b4d.gif
Stage 3: https://puu.sh/BfzBT/a27dd49b4a.gif

My assumption is whatever settings for the rear brake lights are mixed up between stage 3 and 1, but I'll defer to your knowledge on the subject.

This was not an issue when this code was running on Windows.

Even if you could point my to where that is happening in your code would be helpful!

Describe the bug
A clear and concise description of what the bug is.
Every time I leave a police car for the 1st time the UI control panel on corner disapears and never shows up

To Reproduce
Steps to reproduce the behavior:
spawn a car and try
Expected behavior
A clear and concise description of what you expected to happen.
I was the UI control panel would keep on screen while in the car
Screenshots
If applicable, add screenshots to help explain your problem.

ELS Information:
Version #:last stable one from github
Server Version #: dont know
Screenshots of Config.lua, vcf.lua, vcf folder:

Additional context
Add any other context about the problem here.

Describe the bug
hello radio problem

To Reproduce
that's when I run my server and I spawn a vehicle everything is fine, it works well but the times when I get off the vehicle and I go back everything disappears and when I press the button it puts me the game radio instead control of the lights

Expected behavior
I was expecting to get back in the car is that everything works well considering that its march at the beginning

Screenshots
sorry I do not know or take the screen

ELS Information:
Version #:
Server Version #:
Screenshots of Config.lua, vcf.lua, vcf folder:

Additional context
Add any other context about the problem here.