Code Monkey home page Code Monkey logo

Comments (10)

futtta avatar futtta commented on July 3, 2024 1

git log says 012afaf (i.e. you commit 3 days ago).

from jsmin-php.

glensc avatar glensc commented on July 3, 2024

Can you confirm this is still an issue?

as I see from 2.4.0 changelog this was addressed via #7:

from jsmin-php.

futtta avatar futtta commented on July 3, 2024

Just did a test with the current code on my localhost machine and yes, this is still an issue;
image

from jsmin-php.

glensc avatar glensc commented on July 3, 2024

Please send a PR with a proposed fix. Also, include the exact version that you tested with.

from jsmin-php.

futtta avatar futtta commented on July 3, 2024

afraid I don't have a proposed fix.

version tested was a fresh clone of the git repo, using master branch.

from jsmin-php.

glensc avatar glensc commented on July 3, 2024

for posterity, include the actual version or commit hash.

from jsmin-php.

PLUS-RobertEhrenleitner avatar PLUS-RobertEhrenleitner commented on July 3, 2024

Addressed by PR #17

from jsmin-php.

PLUS-RobertEhrenleitner avatar PLUS-RobertEhrenleitner commented on July 3, 2024

I added a test case.

from jsmin-php.

glensc avatar glensc commented on July 3, 2024

forgot to check PR uses issue close patterns

closing manually

from jsmin-php.

glensc avatar glensc commented on July 3, 2024

thanks. released as 2.4.3

from jsmin-php.

Related Issues (6)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.