Code Monkey home page Code Monkey logo

Comments (6)

mrclay avatar mrclay commented on June 24, 2024

Is this really necessary? This seems quite difficult since the files have been moved around several times. The stuff I'd want to keep:

(all current files)
min/lib/JSMin.php
lib/JSMin.php
lib/jsmin.php
lib/Minify/3rd_party/jsmin.php
lib/Minify/Javascript.php
min_unit_tests/test_JSMin.php
min_extras/unit_tests/test_JSMin.php
min_unit_tests/_test_files/js/
min_extras/unit_tests/_test_files/js/

from jsmin-php.

glensc avatar glensc commented on June 24, 2024

yes, git ls-files from current master should be kept

i'll try to make up something in my fork and see

from jsmin-php.

glensc avatar glensc commented on June 24, 2024

here's something i quickly throw together: https://github.com/glensc/jsmin-php/tree/rebase
and one with files on master only: https://github.com/glensc/jsmin-php/tree/rebase-only-master
and the above with empty commits removed: https://github.com/glensc/jsmin-php/tree/rebase-only-master-no-merges2

and finally as you wanted it:
https://github.com/glensc/jsmin-php/tree/rebase2
(but it seems broken, will check tomorrow this)

from jsmin-php.

glensc avatar glensc commented on June 24, 2024

so if you still think it's good idea, you should probably fetch the wanted master branch, git reset hard and push -f to github to ovewrite your master with the new one. (can give exact commands if needed).

and after that the pull requests should work fine.

from jsmin-php.

mrclay avatar mrclay commented on June 24, 2024

Your filtering looks good. Still not convinced it's a good idea. This is being used on Packagist; how will it affect those users?

from jsmin-php.

glensc avatar glensc commented on June 24, 2024

really up to you. but packagist problem is what? if tag by same version is recreated, it should no problem for clients to understand git forced push.

close if you reject the idea. otherwise i will have to work more on this, as somewhy last commit removed all files. huh

from jsmin-php.

Related Issues (6)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.