Code Monkey home page Code Monkey logo

Comments (4)

douglase avatar douglase commented on May 28, 2024

as an alternative, a keyword for display_EE and display_profiles to normalize the input image would keep things backwards compatible.

from poppy.

mperrin avatar mperrin commented on May 28, 2024

I would vote for the keyword approach. In particular, the current behavior is useful if you're calculating only a small portion of the PSF so the encircled energy in the PSF doesn't reach up all the way to 1.

display_PSF already has a normalize keyword, so it would be most consistent to just add one to display_EE similarly.

  • Marshall

from poppy.

douglase avatar douglase commented on May 28, 2024

Yep, a keyword seems cleaner. Just made pull request #65.

For consistency, I used the same keyword and options as display_PSF, now with normalize='total' the result for the same data looks good:
display_profiles

from poppy.

mperrin avatar mperrin commented on May 28, 2024

Closed by #65

from poppy.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.