python3 Integer division in poppy/utils.py about poppy HOT 2 CLOSED

@exowanderer Thanks. I agree this needs to be fixed for that specific function, but I don't think it's necessary to change all / 2 to // 2 as you suggest - in many cases in the Fourier optics calculations etc we do want floating point division. I'd have to go case-by-case for each division to check which was intended rather than using a blanket search and replace, and I don't think that's warranted right now.

I made the changes to pad_to_size only, and expanded the unit test for that function to include more tests cases to handle all the possible even and odd parities. The poppy test suite all passes with that change, so I'm going to leave it at that minimal set of changes for now.

from poppy.

It's definitely a case by case issue. I went through all of the division by 2 markers in poppy/utils.py and found that whenever integer division was desired, the code read " / 2"; but if float division was desired, then the code read " / 2.0". So I changed all of the " / 2" to " // 2", but kept all of the " / 2.0" intact.

Note that I only looked at that one file.

The rest is up to you :)

from poppy.