mpdehaan / strider Goto Github PK

copy_from and copy_to is a nice shortcut and we don't want to break existing users in a change, but perhaps we can make it just be a friendly syntactic-sugar version of an insert into something like this:

commands = [
    { type: rsync, from: foo, to: bar },
    "cat this_is_shell_command"
 ]

(And any raw string is just a command).

This would trivially allow multiple rsyncs, and makes way for other command types, like a scp/exec of an inline script or something similar.

Add a CLI option that outputs the AMI ID so Jenkins can easily slurp it up.

--auto-teardown will remove the instance if successfully baked and only works with --bake.

We should add a flag --teardown-requires-success which only tears down the baking machine if it was successful, for debugging (which would also be used with the above flag).

Or maybe rename the flags to make this more clear, or give the flag a string mode, like --teardown-mode=on-success|on-failure|always or something

Occasionally I notice that even though we sleep a bit after SSH so it can start, we occasionally get rsync protocol errors - I imagine this is because SSH hasn't completely started yet. We should check for SSH starting by running some sort of SSH echo command in a retry loop for a bit prior to going for an rsync.