As of January 1 2019, Mozilla requires that all GitHub projects include this CODE_OF_CONDUCT.md file in the project root. The file has two parts:

1. Required Text - All text under the headings Community Participation Guidelines and How to Report, are required, and should not be altered.
2. Optional Text - The Project Specific Etiquette heading provides a space to speak more specifically about ways people can work effectively and inclusively together. Some examples of those can be found on the Firefox Debugger project, and Common Voice. (The optional part is commented out in the raw template file, and will not be visible until you modify and uncomment that part.)

If you have any questions about this file, or Code of Conduct policies and procedures, please see Mozilla-GitHub-Standards or email [email protected].

(Message COC001)

KVC is requiring implicit @objc annotation on classes, which is no longer supported.

https://stackoverflow.com/questions/44762460/swift-4-this-class-is-not-key-value-coding-compliant

Bug description

Base on the DemoApp, I extended the graph like this

Graph declaration https://github.com/ampm/MappaMundi/blob/ampm/reproduce_finpath_bug/UITests/DemoMappaMundi.swift

The shortest way from screen itemDetail to foo_5 should be:

itemDetail->item_action_1->foo_5.

But, it doesn't work all the time, sometimes, it found out a longer path.

I added some code to the MMNavigator.swift for debugging and invoked the navigation testing for 10 times.

    override func invokeTest() {
        for time in 0...10 {
            print("this test is invoking: \(time) times")
            super.invokeTest()
        }
    }
    func testReproduceFindpathError() {
        navigator.performAction(Actions.addItem)
        navigator.goto(Screens.itemDetail)
        navigator.goto(Screens.foo5)
    }

The log shows:

Troubleshooting

At first, I doubted if it's a bug of Apple's GameplayKit ? I created a Playground to verify it.

In that Playground, I copied the graph in UITests and run it for 100 times.

But, the results can't prove my guess, it always returns the correct path.

How to reproduce this bug?

pls feel free to check out this repo
https://github.com/ampm/MappaMundi
branch name: reproduce_finpath_bug
then you can run the case func testReproduceFindpathError() in DemoUITests.swift.

@jhugman Can you give me any clue then I'll try to fix it?

Thanks a lot.

Xcode project has a hardcoded path for the Carthage location, causing a build failure if carthage is installed at a different location:
line 2: /usr/local/bin/carthage: No such file or directory

P.S. I am sorry for not sending a PR for this, cannot do it at the moment.