mozilla-mobile / firefox-ios-open-in-client Goto Github PK

Yesterday I forked this project to replace the use of the deprecated CFURLCreateStringByAddingPercentEscapes method in the Objective-C code (and to correct the character set used in Swift code - an ampersand within a query argument must be escaped).

But Xcode starts crying when you open the project, asks for project file changes and points out that the Swift version in use is so old that it cannot even convert it to the current one any more.
The two years old PR handling the deprecation of openURL handled some of this but as the author didn't mention anything about the project changes, it is still open.

Is somebody still looking after this project? I think it is a helpful example but not in the current state. I would like to reimplement the URL building (in fact, I already did most of it) but I guess it should be one of the maintainers to update the project/Swift metadata.

The icons in OpenInFirefoxClient/Images.xcassets/AppIcon.appiconset/ are missing. A broken gitignore?

As of January 1 2019, Mozilla requires that all GitHub projects include this CODE_OF_CONDUCT.md file in the project root. The file has two parts:

1. Required Text - All text under the headings Community Participation Guidelines and How to Report, are required, and should not be altered.
2. Optional Text - The Project Specific Etiquette heading provides a space to speak more specifically about ways people can work effectively and inclusively together. Some examples of those can be found on the Firefox Debugger project, and Common Voice. (The optional part is commented out in the raw template file, and will not be visible until you modify and uncomment that part.)

If you have any questions about this file, or Code of Conduct policies and procedures, please see Mozilla-GitHub-Standards or email [email protected].

(Message COC001)

firefox://open-url?url=http://www.test.com works
firefox://open-url?url=http://www.test.com:8080 does not

even if there is an http server on 8080