moxystudio / next-compile-node-modules Goto Github PK

Hi there, I would like to hear you about why use your package instead of next-transpile-modules.

Do you mind sharing some details?

https://github.com/martpie/next-transpile-modules/blob/9f9371e/README.md#what-is-the-difference-with-weconext-plugin-transpile-modules

There's some istanbul ignore lines, remove them and add tests for them.

What's happening

When using withCompileNodeModules without the exclude key defined, or without arguments, the webpack doesn't accept the configuration.

Possible issue

From what I can gather, in order to combine the exclude defined in the options object and the default configuration, we do this:

exclude: [
  ...toArray(ruleOptions.exclude),
  // Next.js >= v9.1.5 is now inlining statements through `babel-plugin-transform-define`, see https://github.com/zeit/next.js/blob/d64587e1a3af11411a6c458ae9544950dfba7825/packages/next/build/webpack/loaders/next-babel-loader.js#L185
  // However, the `process.browser` inlining was causing problems with Webpack builtin
  // `node-libs-browser` (mock) and `node-process`
  /[\\/]node_modules[/\\](node-libs-browser|process)[/\\]/,
],

However, if exclude is not defined in the options object, we will be spreading an array [undefined], which will cause the first element of the array in the final exclude option to be undefined, causing the webpack process to fail.

We need to change this to a conditional spread.

Next's latest versions have MultiThread optimization implemented: https://github.com/vercel/next.js/blob/435bf657847329c753b6c0633f6580a62dddb8ba/packages/next/build/webpack-config.ts#L753

This package should support these updates. In order to do this, the cache-loader config should be changed.