mourner / bbtree Goto Github PK

So, which one was the fastest algorithm? This is nowhere mentioned and the test script doesn't indicate one.

Thanks for this project. Good stuff. I noticed one small defect, which has a quick fix:

There is a minor typo in llrb.js, in the remove(h, key, compare) method, line 111 currently, where it uses “val”, instead of “value”. This results in the value of the removed node being retained, and the value of another node being lost. Easy fix: just change the two instances of “val” on that line to “value”. Seems to work great after that.

Hi, this is a neat implementation.

But your find() function does not consider empty trees, so searching in an empty tree causes an exception to be thrown (which is usually no expected behavior on collections).

Adding an if-null-return test fixes this issue:

find : function (key) {
	    if( !this.root ) 
		return null;
            var node = this.root,
		compare = this._compare;

            while (node !== bottom) {
		var c = compare(key, node.key);
		if (c === 0) return node;
		node = c < 0 ? node.left : node.right;
            }
            return null;
    };

Greetings!