mosheberman / mbtileparser Goto Github PK

Should we start off on a new branch for SpriteKit or a new repo?
Maybe the code could be agnostic to what backing parts are implemented?

I mean if we could implement some sort of a protocol that SKSprite and related UIKit classes could conform to, then both UIKit and SpriteKit could be supported.

Then separate them within a cocoapods-subspec if you only need the SpriteKit version, e.g. Mac OS.

As it is now, the joystick dispatches movement events when it is touched, or when touches move. The correct, more comfortable way to use the joystick would be to support dispatches at regular intervals. Perhaps this should be done in the gameControllerViewController instance.

The movement is jaggy on iPhone but on tvOS it's completely unacceptable.

NPCs should have a canMove and canTurn flag, that will be checked before attempting to perform any further movement or turn checking.

Building tiles should turn semitransparent when characters walk behind them, so that you can see the character. As it stands, players who walk behind buildings are practically invisible and can easily get lost.

Movement Completion Block Doesn't differentiate between Failed and Successful movement. The completion block should take a boolean parameter to determine if movement took place or not.

I'd like to move to SpriteKit if possible. Not a terribly complicated thing to do here - I think there are only a few places that need changes.

The joystick class sometimes returns weird values for velocity. When isDPad == YES and a given axis is at a 1 or -1, the other axis will return strange values.

NPCs should have a "random turn without moving" method.

Centering thumb image fails if background image isn't set, because there's no background image...

In the cocos2d engine, the sprite was manually offset. It seems that this offset causes breakage in the UIKit engine and must be fixed somehow or another. Sprites look funny now.

Water tiles should not be walkable.

There's a leak at 131 line of MBMapView.
CGImageRef image = CGImageCreateWithImageInRect(tilesheet.CGImage, tileRect);

Maybe should add Release line to 140
CGImageRelease(image);

Character Controlled by Joystick will step left, before moving right when the right side of the joypad is pressed.