morganlutz / robin-bot Goto Github PK

Instead, show a message such as "No one's on your prank list".

Add an event listener for when a user leaves/joins and update the member list cache by calling BotKitHelper.getMembers(true). No need to do anything with the output of the function.

https://github.com/morganlutz/robin-bot/blob/master/utils.js#L42

This should say module.exports

https://github.com/morganlutz/robin-bot/blob/master/botKitHelper.js#L29

Here you can store a reference to RobinBot.prankedUsers[member.name] within the member object. That way you can easily access the prank data for that member. To do this you'll need to check if the member is in the prank list, and then you can do something like member.prankData = RobinBot.prankedUsers[member.name]. Under that return true and outside the if return false.

Change Extension and Utils to constants in utils.js. Their values should never change.

This command will list the currently pranked users and who pranked them.

Example output:

Pranked by morgan: raggles, bob
Pranked by raggles: fox

https://github.com/morganlutz/robin-bot/blob/master/app.js#L16

This line should be RobinBot.tokens = {};

https://github.com/morganlutz/robin-bot/blob/master/app.js#L100

Consider using a switch statement and checking for pranked instead of splitMsg[1] just once.

e.g.:

if (pranked) {
  switch(splitMsg[0]) {
  case 'PRANK':
    …stuff…
    break;
  }
  …more cases…
  default:
    …"Holy Try again, that I don't know what to do with the command splitMsg[0]…"
} else {
  …"Holy Try again, send an empty message…"
}

Perhaps by passing "all" to the "forgive" command, it'll delete all of the pranked users pranked by the sending user.

When attempting to prank a member that isn't in the channel, you receive a success message, but the user isn't really pranked and won't appear in the pranked command.