morchickit / intro-data-capstone-biodiversity Goto Github PK

Very nice job coming to the least verbose implementation of this operation

You're at the point in your Python learning curve where you probably won't be able to get away with PEP-8 violations much longer. Consider using one of the many tools (I personally like flake8) which can act as the PEP-8 equivalent of a spellchecker.

An example:

Avoid reinventing the wheel - the default value for .head() is 5 and Jupyter will pretty print the return value for the last line of a cell better than the built-in print function can.

It's totally fine in this exercise, but going forward always consider being as specific as possible with merge and join commands. It is often appropriate to examine and test for successful, as-expected results for your merges at implementation time.

You have a complete, visually engaging, explanatory presentation. It checks all the boxes and it comes to the correct conclusions. I only had a few notes:

• Because you only give relative values in your observations slide, the information is not actionable
• Conforming your graphs to your color scheme would make the presentation more presentable
• You do a good job of balancing white space and graphics with text in most slides
• A "thank you" slide at the end is often a good idea

Nice work! While you've got some room for improvement in your code and presentation, your submission easily checks all the boxes for this Capstone. I get the impression from your code that you might not feel quite comfortable exploring alternative methods and practices, and that when you learn a method you learn it very well.

In terms of improvement, I think spending more time applying PEP-20 to your practices would serve you very well. In a separate issue I also recommended that you look into adopting a tool for checking you compliance with PEP-8. I think that you may also benefit from taking on a project with "no safety net" using data copied from an open data portal or that you are already familiar with.

If you want to go deeper with this project I think you could revisit the presentation, perhaps even giving it a mock run with friends/family. There are additional data viz opportunities that you can pursue in the project as well, if you'd rather focus on the coding portion.

Congratulations on finishing the class!

Return frequently to PEP-20: Avoid placing any unnecessary lines of code between variable assignment and calls. Avoid assigning variables except when readability or functionality is improved.