Create a New Shared Column from a View about moonshine-ide HOT 5 CLOSED

Some other designs that we discussed, for reference.

I originally was thinking of this design:

1. Right-Click > New Shared Column
2. Moonshine opens New Shared Column prompt. User fills this out
3. The Shared Column is created, and is automatically appended to the open view. The Shared Column editor opens
4. User can edit the shared column as desired.

This could be a convenient feature, but converting an existing column is more flexible.

@feather812002 originally implemented this design:

1. User creates a column and edits it as desired
2. Right-Click > Create a new shared column from selected column
3. The new shared column is created using the Header Text as the file and name. If the name already exists, show an error.
4. The column still shows up as a normal column in the original view
5. Remove the current column
6. Add the shared column, and move it to the expected solution

Step 3 saves a click for the simplest case, but it also blocks some cases, which would take more clicks to work around. There may be some cases where the user doesn't want to automatically replace the column in step 4, but the user can do the same thing by closing the view without saving in the proposed process.

from moonshine-ide.

@JoelProminic
I already done this on the selected column , but it not work to the right click column until now .
because for now we selected column hight light it and all code logic work around the selected column ,
if you want the mouse over and right click target column as the work column , it need more refactory the logic at now
at least it need detect and calculation the current right click column when you right-click mouse on some column.

and about the 4 step, the auto updated in-memory and flagged as edited,but please don't click the "Code" tab in the visual editor, because when you click the "Code", the logic will save the update memory column object into local file.
So, if you not save and not click the "Code" tab, the local file will not update for new shared column convert progerss.

from moonshine-ide.

I am starting work around the right-click column as the create new shared column target at now .
and I already commit my previously update.

from moonshine-ide.

I created a new issue, #1220 to add a proper warning for duplicate file names.

In addition, I found that the Create button was disabled on in the button initially, even if the name was not a duplicate. I could fix this by making a change an then reverting to the original name.

For the Code tab, @feather812002 confirmed that for Forms, the Code tab is generated in-memory rather than updating the .form or intermediate XML file. I would like views to work the same way. The Code tab should not work as a save button.

from moonshine-ide.

This looks good in my tests:

Note that there is a major issue with saving the subforms reported here

from moonshine-ide.