Deploy to Vagrant Server popup should have ability to edit launch url about moonshine-ide HOT 9 CLOSED

I tested it on macOS and it works

from moonshine-ide.

FYI, I was planning on making improvements to baseURL in the Vagrant instance /info output so that this should be less necessary: STARTcloud/hcl_roles#1

from moonshine-ide.

I did some tests, and I think this is a good feature even if I make improvements to baseURL. :

I noticed that the application name is not populated in this case before js-debug. Was this problem introduced with the change for this issue?

Some UI thoughts:

• Is the Change URL toggle necessary? We could just give the user the URL as a text field and save a click
• If we do want to keep the "Change URL" button, I think the label should change when it is in edit mode. Perhaps "Cancel" would make sense?
• The text field should expand to fit the panel, similar to Target Directory.

from moonshine-ide.

Good point @JoelProminic - I will remove "Change URL" - no need actually for additional steps.

from moonshine-ide.

I have committed following changes:

• "Change URL" has been removed
• Text field has been expanded to full width
• I have fixed lack of application name in default url

Next build should have all these changes.

from moonshine-ide.

@JoelProminic You can test this issue with newest build. Any additional improvements raise separate issue please.

from moonshine-ide.

Reopen for small improvements

from moonshine-ide.

This feature finally working. I'm closing it.

from moonshine-ide.

This feature came up in #1217. I see that it will automatically change the base URL to match automatically imported Vagrant instances, but manually created instances (i.e. "http://127.0.0.1:8095" for nsf-converter-portal) default to http://127.0.0.1:8080

Note that in the near future I hope to add a property to the /info page in the Vagrant instance that will supply a base URL, so we should be able to implement a more flexible solution with that.

from moonshine-ide.