Navigation Between Tabs Broken on macOS Build about moonshine-ide HOT 14 CLOSED

I checked the current build I had installed:

And I see that Ctrl+Tab and Shift+Ctrl+Tab work as expected.

UPDATE: this also works with the latest build, 3054. I'm testing with macOS Catalina on this workstation.

from moonshine-ide.

Tested with AIR 50.2.2.1 on macOS Ventura - the key-capture still seems to be broken. CTRL+Tab not firing at all or captures by the KeyboardEvent.KEY_DOWN. In following cases I found the listener fires and don't fires:

Since @JoelProminic reported that he found this working on Catalina or in earlier macOS, we might left it this way, or set a new key-combination for this functionality. I propose following options, let me know what you think.

1. CTRL+R and CTRL+Shift+R
2. ALT+Tab and ALT+Shift+Tab

from moonshine-ide.

I would prefer to save the R options for something else, if we aren't using them already.

The ALT options make more sense, but note that they are used for switching windows on Windows machines. We could continue using the old shortcut for Windows.

from moonshine-ide.

The new key-combination on macOS for jumping between tabs are:

ALT+Tab - return to previous tab
ALT+Shift+Tab - opens opened tab list

Windows key-combinations did not changed and remains as was in previous.

I moved this in current milestone as this a small fix.

from moonshine-ide.

Using Tab key seems to become problematic on macOS; Today, when I tested with the latest build, I see the combination with Tab key triggers occasionally in Moonshine. When the last fix applied, it was working appropriately, though.

I'm looking into this again.

from moonshine-ide.

We were seeing some problem on macOS recently, here was my observation after some investigation:

• Previous tab toggle keyboard-shortcut do not works (alt+Tab)
• Opening tab listing/menu do not works (alt+Shift+Tab), opens occasionally
• Selecting tab-item from opened listing/menu do not correctly selects tab
• Internal exception thrown when listing/menu dismissed with Escape

Today I worked on this, and here's my test matrix after the fix:

These can be tested in a new Development build.

from moonshine-ide.

@rat-moonshine Take a look please on bamboo. Build on Actions are failing, so there is good chance it's failing there as well.

from moonshine-ide.

Thank you, for mentioning @piotrzarzycki21 . I see a reference left of a non-existing method. This is now fixed, re-build started on Bamboo.

from moonshine-ide.

I was in impression that it's working correctly, based on my tests earlier; But it appears to be broken probably because latter changes. I commit a fix again, this should work now accordingly, in newer build.

from moonshine-ide.

When I tested earlier today, I found that if I closed the Alt-Shift-Tab menu with Esc, the menu temporarily did not open again with Alt-Shift-Tab . This was fixed with the latest build.

I am seeing that Alt-Tab fails to work in some edge cases like this:

• Application has just opened, so there is no previous tab
• Closing tabs

This feature seems to be working well with the standard use cases though, so I don't want to spend too much more time on it for this release.

from moonshine-ide.

I am seeing that Alt-Tab fails to work in some edge cases like this:

• Closing tab

While investigating the said scenario, I noticed that selected-tab index incorrectly changed after a tab-close event, i.e. in following screen selected index is 3:

When a previous non-selected tab closed, i.e. 1st, it was expected that the tab with title "em202.tph" remain selected, but selected-index changed to:

This is now fixed.

However, in similar situation when previous-tab being closed and tab-toggle happens, I'm a bit unsure how we wants to handle it. We could choose either:

1. Select next or previous tab of last-visited tab that being closed
2. Do nothing

from moonshine-ide.

However, in similar situation when previous-tab being closed and tab-toggle happens, I'm a bit unsure how we wants to handle it.

I looked into how other IDEs function in this case, i.e. IntelliJ, FB; and adjusted tab-jump logic to closely match them. This should be good now.

Please, report any unexpected problem if may erupt.

from moonshine-ide.

Hopefully, the only non-working thing, that we found earlier was:

1. Open tab A from sidebar
2. Open tab B from sidebar
3. Try alt+Tab
4. Nothing changed (Bug)

This behaviour is now rectified, and previous tab jump works against newly opened tabs.

from moonshine-ide.

I did some tests with the latest build, and I don't see any problems with opening new tabs now. I'm closing this issue.

from moonshine-ide.