moonsharp-devs / moonsharp Goto Github PK

See https://groups.google.com/forum/#!topic/moonsharp/LWu5NoPju2Y

• Improve CallbackFunction.FromMethodInfo
• Make StandardUserDataMethodDescriptor public
• Make StandardUserDataPropertyDecriptor public

All error messages in compilation phase are not very helpful.
Plus they are different from Lua standards, lack source reference, etc.

In 301 basic test, these were temporarily commented out with " ERRORMSG " comments.

This issue was created in Task Tub

• Support custom descriptors
• Support different policies for unregistered types
• Support overloads in some way
• Support automatic case conversion as an option

public static void InitUserData()
{
var userDataTypes =
from t in Assembly.GetExecutingAssembly().GetTypes()
let attributes = t.GetCustomAttributes(typeof(MoonSharpUserDataAttribute), true)
where attributes != null && attributes.Length > 0
select t;

foreach (var userDataType in userDataTypes)
{
UserData.RegisterType(userDataType);
}
}

Test blocks temporarily ignored.

https://groups.google.com/forum/#!topic/moonsharp/LWu5NoPju2Y

In Lua 5.2, this code:

function showTable(t)
    for i, j in pairs(t) do
        print(j)
    end
end

tb = {}
tb["id"] = 3

print("Before:")
showTable(tb)

tb["id"] = nil

print("After:")
showTable(tb)
print("End")

outputs this:

Before:
3
After:
End

while in Moonsharp it outputs:

Before:
3
After:
nil
End

In my script I want to add and remove a lot of values in a table so I always end up with a huge table filled with nil values, which is useless. table.remove(tbl, pos) don't work because pos must be an integer of the position, and can't be a string for the key like here with the associative array.

The script is TableIntGet.lua, a rather trivial one:

local t = {};
-- C-Lua schneller
for i = 1,10000,1 do
    t[i] = i;
end;

-- interessant! C-Lua ziemlich lahm
for i = 1,100,1 do
    table.remove(t, i + 1000);
end;
for i = 1,100,1 do
    table.insert(t, i + 1000, 1);
end;

-- C-Lua schneller
local sum = 0;
for i = 1,10000,1 do
    sum = sum + t[i];
end;

The exception is:

MoonSharp.Interpreter.ScriptRuntimeException: attempt to perform arithmetic on a nil value
   at MoonSharp.Interpreter.Execution.VM.Processor.ExecAdd(Instruction i, Int32 instructionPtr) in c:\git\moonsharp\src\MoonSharp.Interpreter\Execution\VM\Processor\Processor_InstructionLoop.cs:line 806
   at MoonSharp.Interpreter.Execution.VM.Processor.Processing_Loop(Int32 instructionPtr) in c:\git\moonsharp\src\MoonSharp.Interpreter\Execution\VM\Processor\Processor_InstructionLoop.cs:line 283
   at MoonSharp.Interpreter.Execution.VM.Processor.Call(DynValue function, DynValue[] args) in c:\git\moonsharp\src\MoonSharp.Interpreter\Execution\VM\Processor\Processor.cs:line 61
   at MoonSharp.Interpreter.Script.Call(DynValue function) in c:\git\moonsharp\src\MoonSharp.Interpreter\Script.cs:line 269
   at MoonSharp.Interpreter.Script.DoString(String code, Table globalContext) in c:\git\moonsharp\src\MoonSharp.Interpreter\Script.cs:line 202

The script is executed via a simple DoString(). Both LuaInterface and NeoLua handle it without any errors.

https://groups.google.com/forum/#!topic/moonsharp/LWu5NoPju2Y

Currently Antlr4 runtime is not a dependency in the nuget package, but forced as a reference. This is intentional, otherwise the nuget package wouldn't work with frameworks 4.x.

The side effect, however, is that any project which uses Moon# and Antlr4 for other scripting uses, has a conflict.

8 queens crashes:

N = 8

board = {}
for i = 1, N do
    board[i] = {}
    for j = 1, N do
    board[i][j] = false
    end
end

function Allowed( x, y )
    for i = 1, x-1 do
    if ( board[i][y] ) or ( i <= y and board[x-i][y-i] ) or ( y+i <= N and board[x-i][y+i] ) then 
        return false 
    end
    end     
    return true
end

function Find_Solution( x )
    for y = 1, N do
    if Allowed( x, y ) then 
        board[x][y] = true 
        if x == N or Find_Solution( x+1 ) then
        return true
        end
        board[x][y] = false          
    end     
    end
    return false
end

if Find_Solution( 1 ) then
    for i = 1, N do
    for j = 1, N do
        if board[i][j] then 
        print( 'Q' )
        else 
        print( 'x' )
        end
    end
    print( '|' )
    end
else
    print( 'NO!' )
end

The frontier pattern %f might throw an IndexOutOfRangeException
At this moment this is a won't fix.
Consider disabling the pattern.

This crashes:

    public static void Main()
    {
        string code = @"
            function a()
                callback(b)
            end

            function b()
                coroutine.yield();
            end                     

            c = coroutine.create(a);

            coroutine.resume(c);        
            ";

        // Load the code and get the returned function
        Script script = new Script();

        script.Globals["callback"] = DynValue.NewCallback(
            (ctx, args) => args[0].Function.Call()
            );

        DynValue function = script.DoString(code);

        // This raises an error of "attempt to yield from outside a coroutine"
        function.Function.Call();


        Console.ReadKey();
    }

\u{xxxx} with { and } mandatory.

https://groups.google.com/forum/#!topic/moonsharp/tSqnKSJn7_c

Revise Exception ctors, because the string can potentially contain tokens interpreted by string.Format.. see for example InterpreterException ctor.

Should return Type instead.

function x() end
print(x(), 3, x(), 4, x(), x())
Lua : nil 3 nil 4 nil
MoonSharp : nil 3 nil 4

However, for default params it's helpful the way MoonSharp does.

Also, voids must be checked for compatibility with varargs.

Investigate standard on this.
However lua interpreter surely supports it - it is used in dungeon.lua files of Legend of Grimrock, for example.

Patterns are implemented in Lua 5.1 way.

This is to port them to Lua 5.2.

Not urgent for sure - at the moment won't fix.

• Processor.LeaveProcessor must reset m_OwningThreadID.
• Have an option to disable the test anyway, as there are corner cases which are legal and yet would trigger the exception (e.g. switching thread and back inside a clr callback).

Link to google docs file is dead:

The standard library may at points be wildly different - Check here for an overview of the standard library status.

xpcall is a dumb wrapper over pcall.
A "serious" implementation of xpcall requires the debug lib to be useful, which is not portable to moon#.
We might want to just have xpcall spit tracebacks and pcall work as it does now.

Hi,

Please let me know how to resolve this error. I am new to Lua.

Thank you.

Regards,
Suresh

https://groups.google.com/forum/#!topic/moonsharp/LWu5NoPju2Y

https://groups.google.com/forum/#!topic/moonsharp/LWu5NoPju2Y