moneyphp / iso-currencies Goto Github PK

Would you be interested in a MR that will implement the export of the Iso Currencies to a Yaml file using the symfony component?

in Belarus we recently changed BYR to BYN, and imagine we have a data in database in BYR currencies and BYN currencies. And after I upgrade the library to the newest version I will no longer be able to work with old data, because Money\Money doesn't know about BYR anymore, which is wrong, as currency is there forever (as BYB - another ancient Belarus currency).

I am happy to prepare PR at some point, if maintainers say yes it makes sense to add those historical data.

I have seen a few anomalies in the currency data created by this script.

Problem

• Countries in the source without a currency get added to the list with a blank array key, with the last country in the list overwriting all previous countries: https://github.com/moneyphp/iso-currencies/blob/master/resources/current.php#L58
• Handling of EUR, USD and other currencies used by multiple countries. There are multiple countries in the list each claiming usage of EUR (as is expected). In the generated output however, these get overwritten similarly to the above issue with the last country claiming the EUR 'winning' in the list, in the current iteration, Spain: https://github.com/moneyphp/iso-currencies/blob/master/resources/current.php#L10
  (The USD is also affected: https://github.com/moneyphp/iso-currencies/blob/master/resources/current.php#L34)

Possible Solutions

• Do not process entries from the source without a valid currency code. This solves the first problem.
• Do not include country data. As the current implementations in \Money\Currencies\ISOCurrencies does not use country data, this is an easy option. Alternatively;
• Store country data separately. (Can a use case be made for it?)

I get composer dependency errors since I'm using symfony 4.3 components. Would you be able to bump up the dependency version to support symfony/yaml ^4.3 ?

On the app I am currently working we need to show a list of ISO codes and currency names. Since we are pulling in this package (through the use of moneyphp/money) and it already contains al data we need, it would be nice to expose it.

In the ISO, YER has cents like USD, EUR ..etc.
https://github.com/moneyphp/iso-currencies/blob/d66effc1c28c6868f7d782dcc6ba965415ed68e8/resources/current.yaml#L884C8-L884C8

But it is not being formatted like them!
for example (USD) :

    $money = Money::USD(850);
    $currencies = new ISOCurrencies();

    $numberFormatter = new \NumberFormatter('en_USA', \NumberFormatter::CURRENCY);
    $moneyFormatter = new IntlMoneyFormatter($numberFormatter, $currencies);

    echo $moneyFormatter->format($money); // outputs $8.50 correct .

when it comes to YER :

    $money = Money::YER(850);
    $currencies = new ISOCurrencies();

    $numberFormatter = new \NumberFormatter('en_YER', \NumberFormatter::CURRENCY);
    $moneyFormatter = new IntlMoneyFormatter($numberFormatter, $currencies);

    echo $moneyFormatter->format($money); // outputs YER 8 not correct !! it is supposed to be YER 8.50

could anyone tell me what I am doing wrong 🤔?