monero-integrations / monerowhmcs Goto Github PK

Hello
I have WHMCS version 8.7.3
During installation of the module, immediately after searching and clicking on the Activation button, it takes you to a page with all Payment Gateways installed, but Monero is not in the list (((((
I really want to use your modul, but it seems that it needs some very small modifications for the latest version of WHMCS.
Please fix it. And I’m ready to donate a little :)

Fatal error: Call to undefined function strip_slashes() in createinvoice.php on line 17

They can be manually fixed by editing them out, but there probably is a better way to get the whmcs complete path. The current setup assumes whmcs is at the top level domain. The redirect from createinvoice.php as well: window.location.href = '/viewinvoice.php?id=$invoice_id';

I assume this is in the works, because there doesnt appear to be code for this yet?

Oops!
Something went wrong and we couldn't process your request.
Please go back to the previous page and try again.

If the problem persists, please contact us.

« Back to Homepage

For additional assistance, please reference the WHMCS TroubleShooting Guide »

RuntimeException: Syntax error: in 
[...]/modules/gateways/monero/library.php:169
Stack trace:
#0 [...]/modules/gateways/monero/library.php(105): Monero_rpc->validate(true, 'Syntax error: ')
#1 [...]/modules/gateways/monero/library.php(231): Monero_rpc->request('make_integrated...', Array)
#2 [...]/modules/gateways/monero/library.php(292): Monero_rpc->_run('make_integrated...', Array)
#3 [...]/modules/gateways/monero/createinvoice.php(39): Monero_rpc->make_integrated_address('XXXXXXXXXXXXXXXXXXXX...')
#4 {main}

In the monero rpc i have the following log:

2019-01-06 11:50:53.342 [RPC0]  DEBUG   wallet.rpc      src/wallet/wallet_rpc_server.h:66       HTTP [y.y.y.y] POST /x.x.x.x:80/json_rpc
2019-01-06 11:50:53.342 [RPC0]  TRACE   net.http        contrib/epee/include/net/http_protocol_handler.inl:589  HTTP_RESPONSE_HEAD: << 
HTTP/1.1 404 Not found
Server: Epee-based
Content-Length: 0
Content-Type: text/plain
Last-Modified: Sun, 06 Jan 2019 11:50:53 GMT
Accept-Ranges: bytes

img/logomonero.png missing from repo

The Monero Address in the WHMCS config is not used.

I run WHMCS in a /billing sub directory. This breaks a few links within the code. Simply adding a "system url path" variable before the links resolves it.

Also, there is an additional "/" in the link to createinvoice.php , simply removing it cleans up the url display (it still works without this fix obv).

Other than that I just tested this code as working on the latest WHMCS.

Two questions, is there a timeout on the invoice display at all? ...and how does this set up handle multiple people trying to pay at once? Is there no conflicts when 4-5 people try to pay an invoice at once for example?

Anyway, thanks a lot for writing this code!

Hello,

I just want to test this module but looks like is not working for me.. I have configured with multiple remote hosts from this page : https://moneroworld.com/#nodes and non of these are working for me, I did a telnet and works..

RuntimeException: Request have return error: Method not found;
Request: {"jsonrpc":"2.0","method":"make_integrated_address","params":{"payment_id":"4bb9494c6124abd9"},"id":1}; Check the daemon hostname and daemon port settings in the Monero Pyament Gateway WHMCS config. in /home/lifetimehosting/public_html/my/modules/gateways/monero/library.php:169
Stack trace:
#0 /home/lifetimehosting/public_html/my/modules/gateways/monero/library.php(120): Monero_rpc->validate(true, 'Request have re...')
#1 /home/lifetimehosting/public_html/my/modules/gateways/monero/library.php(231): Monero_rpc->request('make_integrated...', Array)
#2 /home/lifetimehosting/public_html/my/modules/gateways/monero/library.php(292): Monero_rpc->_run('make_integrated...', Array)
#3 /home/lifetimehosting/public_html/my/modules/gateways/monero/createinvoice.php(39): Monero_rpc->make_integrated_address('4bb9494c6124abd...')
#4 {main}

Thanks

It would be nice to have multi-language support, otherwise hosts using other languages would have english mixed in the content, which looks unprofessional.

I don't know how feasible this is, but I found this section in the WHMCS Documentation: https://developers.whmcs.com/addon-modules/multi-language/

library.php was missing so I copied it from https://github.com/monero-integrations/monerowp/tree/master/monero

Not sure if that's the same file, but it worked.

Now createinvoice.php is complaining:

Fatal error: Class 'Monero_rpc' not found in /full/path/modules/gateways/monero/createinvoice.php on line 15

It looks like there is a setting for saving an XMR address here: https://github.com/monero-integrations/monerowhmcs/blob/master/modules/gateways/monero.php#L20

Curious if the intention of this was for future use to have something auto withdraw from merchant wallet to external wallet(cold/offline)?

I also see what looks to be a transfer function which has not been used as of yet but seems like it could be used?
https://github.com/monero-integrations/monerowhmcs/blob/master/modules/gateways/monero/library.php#L325-L333

If so it seems like we should be able to just do a sweep_all periodically if that address is defined
https://www.getmonero.org/resources/developer-guides/wallet-rpc.html#sweep_all

via

• an optional cron hook
• upon Invoice paid it sweeps( obviously it would only get previously confirmed unlocked stuff) but would be set and forget without users needing to setup a custom cron.
• aftercronjob hook: https://developers.whmcs.com/hooks-reference/cron/#aftercronjob would just work like magic every 5 mins i think which is the default recommend cron action.

Figured I'd ask before maybe giving it a stab