monero-ecosystem / pymonero Goto Github PK

Hi! i'm collecting some of the best repositories about Monero in one single place, the Monero Ecosystem project. Would be great to have this repo in the ecosystem. Everything will be the same for you and you'll still be the maintainer as before, but you will get the shiny Monero Ecosystem badge on github :P You can find more infos on the meta repository. Let me know your thoughts!

• Wrap Subaddress, SubaddressAccount and SubaddressAccountRow usage to corresponding wallet/api/python/*.cpp files prefixed by "Py" that use shared pointers instead of raw pointers.

• Add these new mapped classes to pywallet_api modules at wallet/api/python/pywallet_api.cpp

-wallet/api/wallet2_api.h as reference

For more info on why this is needed read : http://pybind11.readthedocs.io/en/stable/advanced/smart_ptrs.html#std-shared-ptr

• Complete wallet/api/python/pywallet.cpp mapping (wallet/api/wallet2_api.h as reference)
• Expose it to the pywallet_api module at wallet/api/python/pywallet_api.cpp

Hi @ehanoc. Please see monero-ecosystem/meta#78 (comment) and let me know how you plan to proceed forward.

• Add initial support to include tests after building

• Wrap Pending & Unpending Transactions usage to corresponding wallet/api/python/*.cpp files prefixed by "Py" that use shared pointers instead of raw pointers.

• Add these new mapped classes to pywallet_api modules at wallet/api/python/pywallet_api.cpp

• wallet/api/wallet2_api.h as reference

For more info on why this is needed read : http://pybind11.readthedocs.io/en/stable/advanced/smart_ptrs.html#std-shared-ptr

Has anyone gotten the build to work within docker?
Steps to replicate:

git clone https://github.com/ehanoc/pymonero.git
git submodule update --init --recursive --remote
# Build using all available cores
docker build -t monero .

Of the entire log the below entries point to python not being available within the docker container during runtime:

CMake Error at /usr/local/share/cmake-3.13/Modules/FindPackageHandleStandardArgs.cmake:137 (message):
  Could NOT find PythonInterp (missing: PYTHON_EXECUTABLE)
Call Stack (most recent call first):
  /usr/local/share/cmake-3.13/Modules/FindPackageHandleStandardArgs.cmake:378 (_FPHSA_FAILURE_MESSAGE)
  /usr/local/share/cmake-3.13/Modules/FindPythonInterp.cmake:159 (FIND_PACKAGE_HANDLE_STANDARD_ARGS)
  pybind11/tools/FindPythonLibsNew.cmake:60 (find_package)
  pybind11/tools/pybind11Tools.cmake:16 (find_package)
  pybind11/CMakeLists.txt:33 (include)

If the dockerfile still needs to be customized, please let me know which other dependencies the build may have. I may have time to fix the dockermake

• Wrap AddressBook usage to corresponding wallet/api/python/*.cpp files prefixed by "Py" that use shared pointers instead of raw pointers.

• Add these new mapped classes to pywallet_api modules at wallet/api/python/pywallet_api.cpp

• wallet/api/wallet2_api.h as reference

For more info on why this is needed read : http://pybind11.readthedocs.io/en/stable/advanced/smart_ptrs.html#std-shared-ptr

• Main tree files should not diff from the main fork/tree.
• We want to avoid conflicts with the doc files though