Code Monkey home page Code Monkey logo

momentum-ui's Introduction

momentum-design

license: mit state: alpha

The Momentum Design mono-repository is designed as a single source-of-truth for all Momentum Design related resources. Read more about our assets and token libraries here: https://momentum-design.github.io/momentum-design/en/.

This currently includes the following delivered distributables:

Consumption

Please see consumption guide for resources on how to consume this project.

Contributing

Please see contributing guide for resources on how to contribute to this project.

momentum-ui's People

Contributors

aimeex3 avatar arthusliang avatar bfbiggs avatar boiarchukk avatar collab-ui-bot avatar daanishnasir avatar elenagiere avatar futurethang avatar helen-v avatar holsted avatar iruchipriya avatar jason20020 avatar jbirori avatar khempel avatar niti-owner avatar notnestor avatar pauljeter avatar paulwitty avatar prebisz avatar rituparnadey1807 avatar sbudhia avatar semantic-release-bot avatar shashankcs090 avatar teamop avatar tomwall3695 avatar tricarro avatar vinitkumargoel avatar wzpo avatar yananym avatar yasagraw avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

momentum-ui's Issues

Use className or clsx package for adding multiple classes

Currently, I see that multiple class names are added using javascript strings, it would be better if we use clsx package which is 1.2Kb only for managing it.

Issue Type

Feature Request

Component or Pattern Affected

Most of them

Expected Behavior

Current Behavior

<div
        className={
          'cui-button-group' +
          `${(theme && ` cui-button-group--${theme}`) || ''}` +
          `${(justified && ` cui-button-group--justified`) || ''}` +
          `${(type && ` cui-button-group--${type}` || '')}` +
          `${(className && ` ${className}`) || ''}`
        }
>
</div>

Possible Solution

Using clsx

<div
        className={
          clsx('cui-button-group', {
            'cui-button-group--justified': justified,
            [`cui-button-group--${theme}`]: theme,
            [`cui-button-group--${type}`]: type
          }, className)
        }
>
</div>

This is much cleaner, as you do not have to deal with spaces in the class names and also empty string if the condition is undefined.

Steps to Reproduce (for bugs)

Context

Your Environment

  • Library:
  • Version used:
  • Browser Name and version:
  • Operating System and version:
  • Link to your project:

[Alert] Add onClick handler to alert itself + include accessibility

Currently there's an onHide prop which gets passed to the X button on the Alert. However, all the remaining props are being passed to this X button so there is no way to pass an onClick handler to the outer container of the Alert.

  1. Remaining props should be on the outer container so we can also pass in className and other props
  2. Alert should take handle an onClick handler prop (and also handle key downs for accessibility and keyboard navigation through the AlertContainer list)

Issue Type

Bug Report/Feature Request

Component or Pattern Affected

Alert/Alert Container

Expected Behavior

Clicking Alert should trigger an action

Current Behavior

Clicking Alert does not trigger an action

Possible Solution

  1. Remaining props should be on the outer container so we can also pass in className and other props
  2. Alert should take handle an onClick handler prop (and also handle key downs for accessibility and keyboard navigation through the AlertContainer list)

Steps to Reproduce (for bugs)

Context

Your Environment

  • Library:
  • Version used:
  • Browser Name and version:
  • Operating System and version:
  • Link to your project:

[List] Provide option to not loop with keyboard navigation

Issue Type

Component or Pattern Affected

Expected Behavior

Should have option not to loop through list when reaching the end.

Current Behavior

Using keyboard navigation (up arrow, down arrow) loops through list when reaching the limits.

Possible Solution

Steps to Reproduce (for bugs)

Context

Your Environment

  • Library:
  • Version used:
  • Browser Name and version:
  • Operating System and version:
  • Link to your project:

[ListSeparator] Background color is incorrect on dark backgrounds

screen shot 2019-01-04 at 4 51 58 pm

Issue Type

Bug Report

Component or Pattern Affected

ListSeparator

Expected Behavior

background shouldn't be affected, only the color of the line and the text color

Current Behavior

background color is changed instead of the color of the line
screen shot 2019-01-04 at 4 51 58 pm

Possible Solution

fix colors

Steps to Reproduce (for bugs)

  1. wrap cui--dark div with dark background color around ListSeparator

Context

Your Environment

  • Library:
  • Version used:
  • Browser Name and version:
  • Operating System and version:
  • Link to your project:

[ListItem] throws an error for empty child

When conditionally rendering a section in an list item, an error is thrown on unknown property:

Example code:

function App() {
  const display = false;
  return (
    <div className="App">
      <ListItem type="large" title="List Item">
        <ListItemSection position="left">Left</ListItemSection>
        {display && <ListItemSection position="center">Center</ListItemSection>}
        <ListItemSection position="right">Right</ListItemSection>
      </ListItem>
    </div>
  );
}

Location of error:
https://github.com/collab-ui/collab-ui-react/blob/26bf21d1685f5405cee6909cecea931eb1501862/src/lib/ListItem/index.js#L84

Accessibility for Calendar component

Issue Type

Bug Report

Component or Pattern Affected

Date Picker

Expected Behavior

The voiceover/screen reader should be able to speak out the dates when using the keyboard to select dates, similarly to how it works for https://material.angular.io/components/datepicker/overview

Current Behavior

While using voiceover, and then using keys to select dates, I did not here the voiceover informing the date the current selection is on

Possible Solution

Similar to how material angular does it

Steps to Reproduce (for bugs)

Context

Your Environment

  • Library:
  • Version used:
  • Browser Name and version:
  • Operating System and version:
  • Link to your project:

[CallControl] Should have red background for prop type="microphone-muted" on active

I'm submitting a ... (check one with "x")

Component Affected
CallControl

Current behavior

  1. for prop type="microphone-muted" default background color is #333333 and on active it becomes #07C1E4

default: (background-color: #333333)
image

active: (background-color: #07C1E4)
image

  1. CallControl which have background color: #333333 turns #999999 on hover

hover: (background-color: #999999)
image

Expected/desired behavior

  1. for prop type="microphone-muted" background color should be #FF503C on active and on hover it should be #EB4937

default: (background-color: #333333)
image

active: (background-color: #FF503C)
image

hover: (background-color: #EB4937)
image

  1. CallControl which have background color: #333333 should turn to #2A2A2A on hover

hover: (background-color: #2A2A2A)
image

[Input]: advanced validation has become broken

Issue Type

Bug Report

Component or Pattern Affected

Input

Expected Behavior

Correct warning/error message.

Current Behavior

screen shot 2019-01-29 at 3 37 34 pm

Possible Solution

Steps to Reproduce (for bugs)

Context

Your Environment

  • Library:
  • Version used:
  • Browser Name and version:
  • Operating System and version:
  • Link to your project:

[Input] iconNode prop used by Input does not display correctly

I'm submitting a ... (check one with "x")

Component Affected
Input + Icon

Current behavior
When using the iconNode prop with an <Input> component, if the iconNode is wrapped in something (like a <Tooltip>), the iconNode does not display correctly (should be at end of Input).
04!UNITO-UNDERSCORE!38!UNITO-UNDERSCORE!36

Expected/desired behavior
The content in the iconNode prop should be aligned at the the end of the input.

Reproduction of the problem
If the current behavior is a bug or you can illustrate your feature request better with an example, please provide the steps to reproduce and if possible a minimal demo of the problem via images or video.

render() {
  const iconNode = (
    <Tooltip
      direction="bottom-center"
      tooltip="Rob's Tooltip"
      trigger="MouseEnter"
    >
      <Icon
        name="info_16"
        ariaLabel={'custom icon'}
      />
    </Tooltip>
  );
  return (
    <div className='row'>
      <Input
        name='inputLabel'
        label='Robs Label'
        htmlId='inputLabel'
        iconNode={iconNode}
        inputSize='small-5'
      />
    </div>
  );
}

Please tell us about your environment:
macOS 10.14

  • Toolkit Version version:
    v10
  • Browser: [all | Chrome XX | Firefox XX | IE XX | Safari XX | Mobile Chrome XX | Android X.X Web Browser | iOS XX Safari | iOS XX UIWebView | iOS XX WKWebView ]

[AlertMeeting] alert buttons moves out of view port

YES.

In IE , the meeting alert buttons moves out of the view port.

Issue Type

Bug Report

Component or Pattern Affected

AlertMeeting

Expected Behavior

image

Current Behavior

fc4cd2fe-92bc-4036-8db1-4868d9d2980e

Possible Solution

For IE if we remove max-width style from
{alert-class}__content and {alert-class}__content--wide will fix the issue.

Steps to Reproduce (for bugs)

  1. Launch Internet Explorer.
  2. Go to following link . https://react.collab-ui.com/communication/alert
  3. Click on button from meeting section.

Context

The issue affect webex-teams(web) performance

Your Environment

  • Library: Core
  • Version used: 11
  • Browser Name and version: Internet Explorer
  • Operating System and version: Windows
  • Link to your project:

[EventOverlay] Handle absolute/transform ancestors for dynamic positioning

Discovered using collab-ui with react-virtualized. Essentially if you place something like a Popover or EventOverlay within an absolute or transformed element (or maybe fixed) the dynamic positioning breaks.

Issue Type

Bug

Component or Pattern Affected

Affects things like Popover, but believe the root cause is in EventOverlay.

Expected Behavior

Dynamic positioning should work correctly.

Current Behavior

https://codesandbox.io/s/lv2r35509

Possible Solution

From @bfbiggs:
We aren’t adjusting the parentDims based on an absolutely positioned parent which the ListItem is now behaving as. Need to determine closest transform/absolute ancestor and perform calculations.
I need to handle anytime the origin (top/bottom) is reset to 0 which is applicable to elements with transform or absolute I believe

Steps to Reproduce (for bugs)

https://codesandbox.io/s/lv2r35509

Context

Being able to use react-virtualized or react-window with collab-ui would be awesome!!

Your Environment

  • Library: Core, React, Icons, react-virtualized
  • Version used:
    "@collab-ui/core": "11.7.2",
    "@collab-ui/icons": "4.11.1",
    "@collab-ui/react": "11.9.2",
  • Browser Name and version: Appears to work correctly on Safari.. but broken on FF and Chrome
  • Operating System and version: macOS

[Login] Footer Logo sizing issue on IE11

Issue Type

Bug Report

Component or Pattern Affected

Footer Logo

Expected Behavior

Footer logo should remain same size

Current Behavior

Footer logo stretches as windows size is reduced

1328!UNITO-UNDERSCORE!11272 25

Possible Solution

Steps to Reproduce (for bugs)

  1. Open https://idbroker.webex.com/idb/profile in IE11
  2. Resize browser window so that that width can be reduced
  3. Check Footer logo
  4. Logo is stretched

Context

Your Environment

  • Library: Code
  • Version used: 10.10.0
  • Browser Name and version: IE 11
  • Operating System and version: Windows
  • Link to your project:

[Sidepanel] Links are wonky

I'm submitting a ... (check one with "x")

Component Affected

sidepanel
Current behavior

text in sidepanel problems, things that are not links highlight blue when I hover and things that are only part of them highlight in some cases
Expected/desired behavior
things that are not links should not highlight and things that are links should

Reproduction of the problem
If the current behavior is a bug or you can illustrate your feature request better with an example, please provide the steps to reproduce and if possible a minimal demo of the problem via images or video.

sidepanel.zip

Please tell us about your environment:
MAC OS

  • Toolkit Version version:
    10.33.2
  • Browser: [all | Chrome XX | Firefox XX | IE XX | Safari XX | Mobile Chrome XX | Android X.X Web Browser | iOS XX Safari | iOS XX UIWebView | iOS XX WKWebView ]

Chrome

[Icons] The icons do not render in Firefox Nightly because the font resources are invalid

Issue Type

Bug Report

Component or Pattern Affected

The whole icon library

Expected Behavior

I am expecting the icons to appear properly on screen

Current Behavior

They all look like this:

Possible Solution

Before mentioning possibles solutions, let's understand why this issue is happening.

After various tests, I concluded that the bug only happened in Firefox Nightly (not in Firefox beta nor stable) so I filed a regression on bugzilla .

Two Firefox engineers got back to me explaining that Firefox Nightly is enforcing stricter parsing of webfonts on purpose, ie. to detect badly formed font resources. This stricter enforcement will not be activated in stable yet, but it may happen someday.

There is a similar issue about another font.

Possible Solutions:

  1. Consider it a non-issue since it only affects Firefox Nightly (users can set gfx.downloadable_fonts.otl_validation to false in their settings to fix hide this issue).
  2. Investigate why the font generated is invalid, and fix it.
  3. Use SVG for the icons because they are graphics and not fonts? Bring down the pitchforks, I am trolling 😅 . But genuinely, wasn't it possible to keep icons as SVG and make tree-shaking / dead code elimination work to avoid bundling the huge iconsData.json?

Steps to Reproduce (for bugs)

  1. Visit https://momentum.design/styles/icons/library with Firefox Nightly

Context

There are dozens of us... DOZENS (using Firefox Nightly as the daily browser)!

Your Environment

Firefox Nightly, specifically.

[ButtonGroup] not support Tooltip Wrappered Buttons

I'm submitting a ... (check one with "x")

Component Affected
ButtonGroup

Current behavior
Throw an error if the children is not Button
screen shot 2018-11-15 at 2 05 49 pm

Expected/desired behavior
If we want to achieve the following UI. We may need to support:

<ButtonGroup type='pill'>
  <Tooltip><Button ariaLabel='left'><Icon name='icon-flag_16' /></Button></Tooltip>
  <Button ariaLabel='right'><Icon name='icon-cancel_16' /></Button>
</ButtonGroup>

screen shot 2018-11-15 at 1 40 25 pm

Please tell us about your environment:
OS X 10.14

  • Toolkit Version version:
    v10
  • Browser: [all]

[Alert] Add timeouts to dismiss alerts

Allow alerts to take in a timeout prop so it can be dismissed after a certain amount of time

Issue Type

Feature Request

Component or Pattern Affected

Alert/AlertContainer

Expected Behavior

Current Behavior

Possible Solution

Steps to Reproduce (for bugs)

Context

Your Environment

  • Library:
  • Version used:
  • Browser Name and version:
  • Operating System and version:
  • Link to your project:

Need a new container with 'x' button on top right for quote message feature

Hey there! Before you post an issue here, did you try reporting this to the "Collab UI Q&A" space in Webex Teams? Please ask about your issue there before creating a new GitHub issue.

I'm submitting a ... (check one with "x")

Component Affected
Need a new container for quote message feature.

Current behavior
No container could meet the current need for quote message feature.

Expected/desired behavior
Need a new container with an 'x' button on top right of the box;
https://cisco.invisionapp.com/d/main/#/console/16027196/332376724/preview
screen shot 2018-12-30 at 11 18 33 pm
screen shot 2018-12-30 at 11 18 41 pm

Reproduction of the problem
If the current behavior is a bug or you can illustrate your feature request better with an example, please provide the steps to reproduce and if possible a minimal demo of the problem via images or video.

Please tell us about your environment:
webex teams web client

  • Toolkit Version version:

  • Browser: [all | Chrome XX | Firefox XX | IE XX | Safari XX | Mobile Chrome XX | Android X.X Web Browser | iOS XX Safari | iOS XX UIWebView | iOS XX WKWebView ]

[ModalBody] ngClass will not work on Modal Body

Hey there! Before you post an issue here, did you try reporting this to the "Collab UI Q&A" space in Webex Teams? Please ask about your issue there before creating a new GitHub issue.

I'm submitting a ... (check one with "x")

Component Affected
Modal Body, Modal Header, Modal Footer, List, List Item

Current behavior
ngClass is not supported for the components mentioned above because of the way its accessing class as Input

Avoid

@Input() class

Expected/desired behavior
ngClass should be supported.

Reproduction of the problem
Here is a sample reproduction: https://stackblitz.com/edit/angular-cmid9w?file=src%2Fapp%2Fapp.component.html (check HelloComponent)

Solution: https://github.com/collab-ui/collab-ui-angular/pull/16#discussion_r259599236

@ArthusLiang @pauljeter @elenagiere
Please tell us about your environment:

  • Toolkit Version version:
  • Browser: [all | Chrome XX | Firefox XX | IE XX | Safari XX | Mobile Chrome XX | Android X.X Web Browser | iOS XX Safari | iOS XX UIWebView | iOS XX WKWebView ]

[Icon] not visible with dark background(Black)

Hey there! Before you post an issue here, did you try reporting this to the "Collab UI Q&A" space in Webex Teams? Please ask about your issue there before creating a new GitHub issue.

I'm submitting a ... (check one with "x")

Component Affected
Icon

Current behavior

image

Expected/desired behavior

image

Reproduction of the problem
Mount Icon without color props on a black background div.

core-js dependency in react package causes build failure

While trying to reproduce another ticket (double checking if fonts are being loaded-in correctly without needing to import a CSS file) I encountered a bug where during the build process where a core-js dependency caused a failure
Using codesandbox and parcel (locally) I was a

Issue Type

Bug Report

Component or Pattern Affected

Parcel and Codesandbox are reporting a failure in Accordion but it's really a require issue (core-js or not)

Expected Behavior

Should render the react component

Current Behavior

Parcel's zero-config build process causes a build error with modules required by components

Possible Solution

Move off of core-js and to either babel-present-env or pollyfill.io

Steps to Reproduce (for bugs)

Codesandbox link above has a working example of the bug

Your Environment

  • Library:
  • Version used:
  • Browser Name and version:
  • Operating System and version:
  • Link to your project:

[ListItem] Read Only List Item should not be clickable

Read Only List Item is currently clickable and changes the active state color when clicked. It should not be clickable nor have an active state.

Issue Type

Bug Report

Component or Pattern Affected

ListItem

Expected Behavior

It should not be clickable nor have an active state. Should not have a clickable cursor either

Current Behavior

Read Only List Item is currently clickable and changes the active state color when clicked.

Possible Solution

Hide pointer cursor, don't have active state (is it a button?)

Steps to Reproduce (for bugs)

Context

Your Environment

  • Library:
  • Version used:
  • Browser Name and version:
  • Operating System and version:
  • Link to your project:

[Avatar] Add rich presence states

I'm submitting a ... (check one with "x")

Component Affected
Avatar

Current behavior
Displays avatar presence with option types such as active, inactive, dnd, ooo.

Expected/desired behavior
Expand avatar to include rich presence states such as call, meeting, presenting.

Reproduction of the problem
https://jira-eng-gpk2.cisco.com/jira/browse/SPARK-32577

Please tell us about your environment:
Webex Teams Web Client

  • Toolkit Version version:

  • Browser: [all | Chrome XX | Firefox XX | IE XX | Safari XX | Mobile Chrome XX | Android X.X Web Browser | iOS XX Safari | iOS XX UIWebView | iOS XX WKWebView ]

Misleading Avatar `type` Property Usage Demo

On a demo page this is the code to use:

<div className="docs-example docs-example--spacing">
          <h3>
            <p><code className="small">type=(default)</code></p>
          </h3>
          <div><Avatar title="Tom Smith"/></div>
        </div>

However, default is not an option (anymore?). I got a Proptype warning using default. Therefore, I changed it to "".

[SearchInput] clear icon vertically misaligned for Pill Type

For the SearchInput component, it seems like the "clear" icon is vertically misaligned for the "Pill" type. It looks fine for the "Normal" type. Please see screenshots for examples.

Normal Type
screen shot 2018-12-11 at 12 34 12 pm

Pill Type
screen shot 2018-12-11 at 12 34 58 pm

Browser: Chrome
OS: MacOs 10.13.6

Markup Code:

<div className={[classNames('ciscospark-search-input-wrapper', styles.searchInputWrapper), 'cui--dark'].join(' ')}>
              <div className={classNames('ciscospark-search-input', styles.searchInput)}>
                <SearchInput
                  name="pillSearchInput"
                  htmlId="pillSearchInput"
                  type="pill"
                  inputSize="large-10"
                  onKeyUp={this.handleSpaceFilterInput}
                  onChange={this.handleSpaceFilterInput}
                  clear
                />
              </div>
            </div>

CSS:

.searchInputWrapper {
  font-family: CiscoSans, 'Helvetica Neue', Arial, sans-serif;
  display: flex;
  justify-content: center;
  flex-direction: row;
  padding-top: 1rem;
  -webkit-box-sizing: border-box;
  -moz-box-sizing: border-box;
  box-sizing: border-box;
  background: rgba(0,0,0,1);
  fill: #efefef;
}

.searchInput {
  display: flex;
  justify-content: center;
  align-self: center;
  flex: 1 1 auto;
  margin: auto;
}

[SpaceListMeeting] Support isIMOnlyShare

SpaceListMeeting needs to support isIMOnlyShare prop.
If isIMOnlyShare is set to true,

  1. change the button from green to blue
  2. remove the number of the participant
  3. show Icon share-screen_12instead ofpeople_12

Issue Type

Support Request

Component or Pattern Affected

SpaceListMeeting

Expected Behavior

Support new prop isIMOnlyShare
Screen Shot 2019-03-08 at 9 47 48 PM

Current Behavior

Screen Shot 2019-03-08 at 9 50 36 PM

Possible Solution

Context

Need to accomplish IM only share feature.

Your Environment

  • Library: React
  • Version used:
  • Browser Name and version: Chrome
  • Operating System and version: macOS
  • Link to your project:

[AlertCall] Support IM only share

Issue Type

Feature Request

Component or Pattern Affected

CallAlerts

Expected Behavior

Show Icon share when receiving the IM only share request.
Screen Shot 2019-03-11 at 9 43 28 AM
VD: https://cisco.invisionapp.com/d/main/#/console/16845228/349259633/preview

Current Behavior

Showed Icon camera when receiving IM only share.
Screen Shot 2019-03-08 at 9 58 56 PM

Possible Solution

Context

Accomplish IM only share feature

Your Environment

  • Library: React
  • Version used:
  • Browser Name and version: Chrome
  • Operating System and version: macOS
  • Link to your project:

Items on navigation for mobile device should span whole width

Issue Type

momentum design_ nexus 5x

Component or Pattern Affected

Expected Behavior

Current Behavior

Possible Solution

Steps to Reproduce (for bugs)

Context

Your Environment

  • Library:
  • Version used:
  • Browser Name and version:
  • Operating System and version:
  • Link to your project:

[Icons] Invalid Swift enum creation in CollabIconType.swift

Hey there! Before you post an issue here, did you try reporting this to the "Collab UI Q&A" space in Webex Teams? Please ask about your issue there before creating a new GitHub issue.

I'm submitting a ... (check one with "x")

Component Affected
CollabIconType.swift

Current behavior
Swift icon file enumeration can create invalid Swift enums if the corresponding svg file starts with a number.

Expected/desired behavior
Swift icon file enumeration should create valid enums. There are a couple of options including:

  • Change whatever automate process that creates the CollabIconType Swift file to “spell out” a number when creating the enum if the first character of the svg file starts with a number.
  • Don’t name the svg files so that the first character is a number.

Reproduction of the problem
If the current behavior is a bug or you can illustrate your feature request better with an example, please provide the steps to reproduce and if possible a minimal demo of the problem via images or video.

screen shot 2019-01-07 at 8 58 16 am

Please tell us about your environment:
XCode 10.1

  • Toolkit Version version:

  • Browser: [all | Chrome XX | Firefox XX | IE XX | Safari XX | Mobile Chrome XX | Android X.X Web Browser | iOS XX Safari | iOS XX UIWebView | iOS XX WKWebView ]

Accessibility for Slider

Issue Type

Bug Report

Component or Pattern Affected

Slider

Expected Behavior

I should be able to hear what value is when I interact with the slider, similar to https://material.angular.io/components/slider/examples

Current Behavior

Have no clue what value does the slider has

Possible Solution

Similar to angular material slider

Steps to Reproduce (for bugs)

Context

Your Environment

  • Library:
  • Version used:
  • Browser Name and version:
  • Operating System and version:
  • Link to your project:

[ButtonGroup] Need to adjust the size of the button group

@bfbiggs Hey Ben, the size of the button group is large than the VD, is it possible to make the size of the button group adjustable? Thanks!

VD:
https://cisco.invisionapp.com/d/main/#/console/16027196/348752181/
screen shot 2019-02-25 at 1 01 39 pm
.menu{
height: 24px;
width: 108px;
}

Actual:
screen shot 2019-02-25 at 1 05 56 pm
height: 38px;
width: 178px;

Issue Type

Support Request

Component or Pattern Affected

ButtonGroup

Expected Behavior

Make the size of button group adjustable.

Current Behavior

The size of the button group is too big on the web.

Possible Solution

Steps to Reproduce (for bugs)

Context

Your Environment

  • Library: React
  • Version used:
    "@collab-ui/core": "11.6.7",
    "@collab-ui/icons": "4.9.0",
    "@collab-ui/react": "11.8.0",
  • Browser Name and version: Chrome
  • Operating System and version: Mac
  • Link to your project:https://sqbu-github.cisco.com/stawang2/web-client/

[EventOverlay/Popover]: Unmounting logic creating some errors

These are being listed in tandem because debugging them without the other is not feasible.

When using the EventOverlay/Popover to replicate Combobox functionality - two errors are thrown:

  1. There is no-op error caused most likely by Popover because it is trying to perform an action after the component has already unmounted. Investigate componentWillUnmount logic and possibility of determining if clearTimeout function should run.
  2. Due to the logic in EventOverlay componentDidUpdate, it appears there's the possibility of multiple keyHandlers being added as well keyHandlers being removed prematurely. This requires more investigation, but has to do with the keyHandler change made for enter/esc to work with EditableTextField within the Menu component.
    @robstax

Issue Type

Bug Report

Component or Pattern Affected

EventOverlay, Popover

Expected Behavior

No errors or warnings using the Popover/EO.

Current Behavior

2 console errors being thrown.

Possible Solution

Clean up unMount logic and keyHandler logic.

Steps to Reproduce (for bugs)

Context

The issue appeared when trying to recreate comboBox behavior.

Your Environment

  • Library: React
  • Version used:
  • Browser Name and version:
  • Operating System and version:
  • Link to your project:

[Input] Email validation Input/Button combo

In a couple different places within Webex teams, we do input validation to check whether a string matches a regex pattern for a valid email format. Only once the text value in the component matches the regex do we enable the . It would be nice to have a component that wrapped the Input and Button components to do this sort of thing for us. Here is the regex we use:

/^(([^<>()[\]\\.,;:\s@"]+(\.[^<>()[\]\\.,;:\s@"]+)*)|(".+"))@((\[[0-9]{1,3}\.[0-9]{1,3}\.[0-9]{1,3}\.[0-9]{1,3}\])|(([a-zA-Z\-0-9]+\.)+[a-zA-Z]{2,}))$/

Issue Type

Feature Request

Component or Pattern Affected

None? It's a new component

Expected Behavior


Possible Solution

Make a component that wraps the Button and Input components like I mentioned above and include the functionality I mentioned with a regex such as the one I listed above.

<SPIKE> Eslint/Prettier Destructuring Object

Research if there is a solution to force destructuring past two properties onto a new line. Write stories to update libraries.

i.e.

import { a, b c } from 'd';

should be

import {
a,
b,
c
} from 'd';

[Avatar] Allow custom Avatar Component to be rendered in CompositeAvatar

We would like to be able to pass our own Avatar Component to the CompositeAvatar Component. Our custom Avatar component would essentially render the Collab Avatar Component, but we want to do some processing in our component as well.

Issue Type

Feature Request

Component or Pattern Affected

CompositeAvatar

Expected Behavior

Be able to pass own Avatar Component

<CompositeAvatar>
  <CustomAvatar/>
  <CustomAvatar/>
</CompositeAvatar>

Current Behavior

Can only pass Collab Avatar

<CompositeAvatar>
  <Avatar/>
  <Avatar/>
</CompositeAvatar>

Possible Solution

somehow check if underlying component is the collab Avatar component?

Steps to Reproduce (for bugs)

  1. Render Custom Avatar inside CompositeAvatar

Context

We have a ParticipantAvatar which does some processing to fetch the participant avatar and display it. We would like to display this avatar in the CompositeAvatar

Your Environment

  • Library: React
  • Version used: Latest
  • Browser Name and version: all
  • Operating System and version: Mac
  • Link to your project: web-client

[ButtonGroup] Pill Styles

Hey there! Before you post an issue here, did you try reporting this to the "Collab UI Q&A" space in Webex Teams? Please ask about your issue there before creating a new GitHub issue.

I'm submitting a ... (check one with "x")

Component Affected
ButtonGroup

Current behavior
Active style can't be modified because it's being programatically removed in the ButtonGroup component.

Expected/desired behavior
If the default active style should be trasparent, than that style could be applied in the css so that it can be overwritten.

Reproduction of the problem
If the current behavior is a bug or you can illustrate your feature request better with an example, please provide the steps to reproduce and if possible a minimal demo of the problem via images or video.

Please tell us about your environment:

  • Toolkit Version version:

  • Browser: [all | Chrome XX | Firefox XX | IE XX | Safari XX | Mobile Chrome XX | Android X.X Web Browser | iOS XX Safari | iOS XX UIWebView | iOS XX WKWebView ]

[CallControl]: allow colorObj as props to customize background color

Issue Type

Feature Request

Component or Pattern Affected

CallControl

Expected Behavior

  • background-color and border collab styles value should be customizable based on the colorObj props value. If colorObj is null/undefined then the styles value should be default (as it is now)
  • As an instance
  1. In meeting, CallControl type= microphone-muted default color is black and it turns to red on active, but as per requirement when microphone-muted CallControl collapsed to the center, we want its background-color to be lighten by some opacity and border to be set with color red as below -
    microphone-muted!UNITO-UNDERSCORE!navigation
  2. Similarly, In roster panel we want some other behavior as below -
    microphone-muted!UNITO-UNDERSCORE!roaster!UNITO-UNDERSCORE!panel

Current Behavior

We have achieved the above mentioned scenario by overriding default behavior.

  1. In meeting case:

Normal mode:


.cui-button--red {
    background-color: rgba($flamingo, .12);
    border: 1px solid $flamingo;
}

High contrast mode:


.cui--contrast {
  & .cui-button--red {
      background-color: rgba($red-base-contrast, .12);
      border: 1px solid $red-base-contrast;
  }
}

  1. Roster panel case:
    Same as above, we have overridden collab styles in this case as well.

Possible Solution

CallControl should allow a props of object type by using which user can pass background-color, opacity, border etc. and these value can be use to decide the backgroundColor and border of CallControl.

Steps to Reproduce (for bugs)

  1. Start any meeting
  2. Mute yourself from meeting controls
  3. When microphone-muted collapsed to center, its background color will be lighten with some border.
  4. If you are a host, go to roster panel and hover participant list, there you will see microphone-muted customized backgroundColor. Mute any user to check muted behavior as well.

Context

Your Environment

  • Library: React
  • Version used:
  • Browser Name and version:
  • Operating System and version:
  • Link to your project:

[Avatar] failure badge is too small

Failure badge icon on avatar is too small.

Issue Type

Enchancement

Component or Pattern Affected

Avatar

Expected Behavior

Screenshot from desktop clients:
12!UNITO-UNDERSCORE!21!UNITO-UNDERSCORE!25

Current Behavior

Screenshot from web client:
12!UNITO-UNDERSCORE!20!UNITO-UNDERSCORE!05

Your Environment

  • Library: Core, React, Icons
  • Version used:
    "@collab-ui/core": "10.39.2",
    "@collab-ui/icons": "3.43.0",
    "@collab-ui/react": "10.0.8",
  • Browser Name and version: Chrome, Firefox, Safari
  • Operating System and version: macOS 10.14.3

Add keywords in the package.json

Hey there! Before you post an issue here, did you try reporting this to the "Collab UI Q&A" space in Webex Teams? Please ask about your issue there before creating a new GitHub issue.

I'm submitting a ... (check one with "x")

Component Affected
Package

Current behavior
Not able to search in tools like ngx.tools

Expected/desired behavior
Adding keywords in pacakge.json should resolve the issue as mentioned here ngxtools/ngx.tools#32

Reproduction of the problem
If the current behavior is a bug or you can illustrate your feature request better with an example, please provide the steps to reproduce and if possible a minimal demo of the problem via images or video.

Please tell us about your environment:

  • Toolkit Version version:

  • Browser: [all | Chrome XX | Firefox XX | IE XX | Safari XX | Mobile Chrome XX | Android X.X Web Browser | iOS XX Safari | iOS XX UIWebView | iOS XX WKWebView ]

Primary Button is not accessible

Issue Type

Bug Report

Component or Pattern Affected

Button

Expected Behavior

Colors should be accessible to all users

Current Behavior

Primary Button is not accessible according to AA or AAA standards

Possible Solution

Black (dark) color instead of white(light) color for the primary button is accessible

Steps to Reproduce (for bugs)

Context

Your Environment

  • Library:
  • Version used:
  • Browser Name and version:
  • Operating System and version:
  • Link to your project:

[Angular] Collab UI Components should be converted to Web Components

Hey there! Before you post an issue here, did you try reporting this to the "Collab UI Q&A" space in Webex Teams? Please ask about your issue there before creating a new GitHub issue.

I'm submitting a ... (check one with "x")

- [ ] bug report
- [x] feature request
- [ ] support request => Please do not submit support request here, instead see https://github.com/collab-ui/collab-ui-angular/blob/master/CONTRIBUTING.md#-got-a-question-or-problem

Component Affected
All

Current behavior
Web Components are not generated

Expected/desired behavior
Using Angular Elements, the components in Collab UI can be converted into Web Components, so that they can be used in any other application, even in Vanilla JS app or with any other framework https://custom-elements-everywhere.com/

[Site]: Reloading momentum.design pages shows 404

Since I am not a Cisco Employee, I could not post in "Collab UI Q&A" space in Webex Teams first.

Reloading pages on momemtum.design (except for the home page), shows 404 page first and then displays the content.

Issue Type

Bug Report

Component or Pattern Affected

Momentum website

Expected Behavior

Reloading pages on momentum.design should displays the content for the page.

Current Behavior

It displays 404 page first and then shows the content

Possible Solution

Don't show the 404 page

Steps to Reproduce (for bugs)

momentum

Context

Your Environment

  • Library:
  • Version used:
  • Browser Name and version:
  • Operating System and version:
  • Link to your project:

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.