I can't really see how substitutions are sorted in teacher mode. Didn't we already implement that at some point? The primary factor should be alphabetical order of teachers, the secondary factor should be the lesson, which obviously is not working well.

Current visual appearance:
All entries have round corners, no shadow

Suggestion:
Only the outer entries have round corners, the collection has a smooth light shadow

https://github.com/MoFa-Development

Sort by class, then subject, then time?
Or Class, time, subject?

However, subject should be relevant

I think it‘s a good idea to add the selected class / teacher to the cookies so people don‘t have to reselect their class / themselves every time.

For some reason, if I filter for 11 there just appears nothing (but it does on oegym.de) (at least today, 23.11.2021). I suspect it has something to do with the collections.

(A good example is on Monday, 06. December 2021)

At least RCS doesn't want us to show the cancelled lessons in this case.
I'm not even sure if it's really sensible to do that though, as (at least) my Physics course was actually cancelled then. I wasn't affected by any of the exams, so it was actually a good thing for me that this cancelled lesson was shown.

This is wrong:
https://github.com/Antricks/substitution-table/blob/object-oriented-refactor/js/settings.js#L87

It should be 90℅ instead of smaller and 100% instead of medium.

But that won't be a problem after settings refactoring is done, just please mind this during refactoring.

It would improve readability if we somehow showed substitutions that correspond to each other. For example, we could use the interchanging background colour for that, so corresponding substitutions get the same background colour. This should also work together with issue #9

We‘re currently just using the normal favicon which isn‘t really optimized for App launchers.

@SpyrexDE
The current settings system (also in object-oriented-refactor) is pretty messy in my opinion.
I think it might be a good idea to rewrite this whole part. Do you want me to help with that?

70% Zoom:

80% Zoom and above:

This is probably due to my rather high screen resolution...

There are instances where there's an extra entry for every substituted lesson. If only the time is different, we could also combine such entries into one.

Tbh, I hate our current white theme:
It's looking kinda dirty and dry

I just created a prototype in the dev tools:
How I would like it to be

If for example a class is split in Latin and French and only the French part of the class actually has a substitution, it appears like the whole class has a substitution. Fortunately, we're not lacking data to detect such a situation - we can use the (so far unused) data field course_long (defined in drawing.js:175).
It's formatted the following way: "SUBJECT_CLASS_TEACHER" - We only need to parse this and check for differences. If there's a difference, we should add some indication about this change.

Error message:

data.js:198 Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'day')
    at window.getCachedDay (data.js:198)

Currently, you can't really see many substitutions at the same time. We should add a switch that forces a more compact layout, so it's better for monitors.

It appears that the long form of course names does not necessarily feature the newest information. So in some cases, using that field actually creates wrong information. We should not touch it anymore and only use data from other fields.

When flipping the monitor mode switch to on, the layout changes as expected but the scrolling only works after a site reload.
This applies to Firefox, Chromium and Safari.

Without caching the user experience will decrease a lot, due to relatively long loading times.
I suggest to always cache one day before and two days after the currently shown day.

Adding the class to every substitution in a collection is unnecessary because they are grouped by exactly that - the class. I think it would improve readability if we somehow showed it just once, maybe on the left of the collection or so...

(Depends on #6 ) We should show the next day, maybe automatically switching when in monitor mode - at least in the afternoon. For that we obviously need to pre-load the next and the current day, which is already mentioned in #6

It would be awesome if the auto-scroll mode wrapped the substitutions back around, so there's no jumping or moving back. Moving back is also an option of course, but it wouldn't be so cool.