mobu-of-the-world / emobu Goto Github PK

View Code? Open in Web Editor NEW

2.0 3.0 1.0 1.67 MB

👥 ⏲️ 🚗 - Mob programming timer

Home Page: https://mobu-elm.web.app/

License: MIT License

Elm 79.13% HTML 2.35% TypeScript 3.59% CSS 10.77% Nix 4.16%

elm mob-timer mob-programming mob-programming-timer

emobu's Introduction

emobu

A mob-programming timer

License

MIT

Authors

Kenichi Kamiya (@kachick)

emobu's People

Stargazers

Watchers

Forkers

kachick

emobu's Issues

Notifications

mobu-of-the-world/mobu#13

Personally I don't use these notifications. Especially this tool, it looks needless (sound should be better)🤔

Replace vite with another hot reloading methods

Depending to vite and hmsk/vite-plugin-elm made a blocker in every year

#428 (comment)
#188 (comment)

And dropping vite dependency may help #366

Candidates

https://discourse.elm-lang.org/t/introducing-elm-watch-elm-make-in-watch-mode-fast-and-reliable/8653/6
https://github.com/lydell/elm-watch
https://github.com/eradman/entr/

Divide mandatory data and flags

emobu/src/Main.elm

Lines 26 to 27 in fdf4130

    
           init : Json.Encode.Value -> ( Model, Cmd Msg ) 
        
           init flags =

Many maybe sounds ugly to me. How about to split them to 2 Json?

Replace Node.js with Deno

Why?

Managing lots of configs around linters and dealing with the Node.js ecosystem is a pain for me.

How

Tried 3 times

#317
#318
#360 is a way, but dropping Vite does not make better developer experience for now.

Deno blocks non JS/TS importing is a reason. How about denoland/deno#11961 (comment) workaround?

Replace duration handler with special HTML elements if available

emobu/src/Main.elm

Lines 526 to 560 in d192a47

    
           newIntervalFields : Model -> Html Msg 
        
           newIntervalFields model = 
        
               let 
        
                   ( hoursOptions, minutesOptions, secondsOptions ) = 
        
                       MobSession.newIntervalOptions model.intervalSeconds 
        
                   optionsFormatter = 
        
                       List.map 
        
                           (\( val, selected ) -> option [ Attr.value val, Attr.selected selected ] [ text val ]) 
        
               in 
        
               div [ Attr.class "interval-input" ] 
        
                   [ text "/" 
        
                   , space 
        
                   , select 
        
                       [ Attr.class "value-select" 
        
                       , onInput (UpdateInterval MobSession.Hour) 
        
                       , Attr.disabled model.mobbing 
        
                       ] 
        
                       (hoursOptions |> optionsFormatter) 
        
                   , text ":" 
        
                   , select 
        
                       [ Attr.class "value-select" 
        
                       , onInput (UpdateInterval MobSession.Min) 
        
                       , Attr.disabled model.mobbing 
        
                       ] 
        
                       (minutesOptions |> optionsFormatter) 
        
                   , text ":" 
        
                   , select 
        
                       [ Attr.class "value-select" 
        
                       , onInput (UpdateInterval MobSession.Sec) 
        
                       , Attr.disabled model.mobbing 
        
                       ] 
        
                       (secondsOptions |> optionsFormatter) 
        
                   ]

whatwg/html#5488 🙏

Prefer nix flake

emobu/default.nix

Lines 1 to 10 in d192a47

    
           { pkgs ? import (fetchTarball "https://github.com/NixOS/nixpkgs/archive/f2406198ea0e4e37d4380d0e20336c575b8f8ef9.tar.gz") { } }: 
        
           pkgs.mkShell { 
        
             buildInputs = [ 
        
               pkgs.nil 
        
               pkgs.nixpkgs-fmt 
        
               pkgs.nodejs_20 
        
               pkgs.dprint 
        
             ]; 
        
           }

emobu/renovate.json

Line 5 in d192a47

"enabledManagers": ["nix"],

Then the definition will be updated by renovatebot

Drag and Drop UI for user order

mobu-of-the-world/mobu#430

Dependency Dashboard

This issue lists Renovate updates and detected dependencies. Read the Dependency Dashboard docs to learn more.

This repository currently has no open or pending branches.

Detected dependencies

nix

flake.nix

nixpkgs nixos-unstable

Check this box to trigger a request for Renovate to run again on this repository

regex for input username validation is broken

I found that when using Mozilla.Firefox.DeveloperEdition and the developer console
It alerts following warnings

Unable to check <input pattern='[a-zA-Z0-9-]{1,39}'> because the pattern is not a valid regexp: character class escape cannot be used in class range in regular expression

Actually inputting !@# will be accepted.

Provide staging environments

Deploy products in all PRs

Update tsconfig that is a missing task in updating to Node.js 20

tsconfig/bases#197
#292
#362
#366

Remove avatarUrl from storage

It always can be generated from username. However currently persisted and often shows fallback images, then it is hard to refresh behaviors by UI.

So I would remove the persisted logics.
And having an idea, providing storage clear button might be better...

Actual time based counter

emobu/src/Main.elm

Line 150 in d65191b

    
           -- TODO: Consider to change calc with current time intead of incrementing seconds. In react https://github.com/mobu-of-the-world/mobu/pull/486

mobu-of-the-world/mobu#486

	newIntervalFields : Model -> Html Msg
	newIntervalFields model =
	let
	( hoursOptions, minutesOptions, secondsOptions ) =
	MobSession.newIntervalOptions model.intervalSeconds

	optionsFormatter =
	List.map
	(\( val, selected ) -> option [ Attr.value val, Attr.selected selected ] [ text val ])
	in
	div [ Attr.class "interval-input" ]
	[ text "/"
	, space
	, select
	[ Attr.class "value-select"
	, onInput (UpdateInterval MobSession.Hour)
	, Attr.disabled model.mobbing
	]
	(hoursOptions \|> optionsFormatter)
	, text ":"
	, select
	[ Attr.class "value-select"
	, onInput (UpdateInterval MobSession.Min)
	, Attr.disabled model.mobbing
	]
	(minutesOptions \|> optionsFormatter)
	, text ":"
	, select
	[ Attr.class "value-select"
	, onInput (UpdateInterval MobSession.Sec)
	, Attr.disabled model.mobbing
	]
	(secondsOptions \|> optionsFormatter)
	]

	{ pkgs ? import (fetchTarball "https://github.com/NixOS/nixpkgs/archive/f2406198ea0e4e37d4380d0e20336c575b8f8ef9.tar.gz") { } }:

	pkgs.mkShell {
	buildInputs = [
	pkgs.nil
	pkgs.nixpkgs-fmt
	pkgs.nodejs_20
	pkgs.dprint
	];
	}

mobu-of-the-world / emobu Goto Github PK

emobu's Introduction

emobu

License

Authors

emobu's People

Stargazers

Watchers

Forkers

emobu's Issues

Candidates

Why?

How

Detected dependencies

Recommend Projects

Recommend Topics

Recommend Org