Code Monkey home page Code Monkey logo

Comments (4)

khvzak avatar khvzak commented on July 17, 2024 1

I found a better way without attaching Option<String> to a WrapperError and seems it works better
fe39ae0

from mlua.

khvzak avatar khvzak commented on July 17, 2024

Thanks for the bug report!

I'm working to fix, and will release 0.6.0-beta.2 soon (sorry, I probably will not backport to 0.5, but hope it's ok).

In 0.6 all functions that can trigger longjmp are moved to the C shim and it's safe to call luaL_traceback (from the C side, checking available stack first for Lua <= 5.3, in 5.4 it's implemented using buffers).
I also like the idea to create a custom (and stack independent) implementation of luaL_traceback.

from mlua.

horazont avatar horazont commented on July 17, 2024

@khvzak Hey, thanks for your reply. I experimented somewhat in #45. This seems to work fine in my use case, but Iā€™m just coming back to Rust after a ... seven year break (time flies!).

I suspect your implementation will be more sound, Iā€™d still appreciate a review if you like.

from mlua.

khvzak avatar khvzak commented on July 17, 2024

I'm preparing v0.6.0-beta.2 release and pushed a commit that should improve stacktrace reporting in the module mode.
I have not yet published it. Could you please check from the master branch does it looks as you expected?
Thanks.

It will report callback error + stacktrace for a most top callback that failed and the main cause, skipping intermediate calls.

--
I don't much like the current approach, but seems not many options available. Ideally tracebacks should be attached to Errors but it would be super breaking change (like wrapping error to Error+Traceback or adding field to each Enum variants).

from mlua.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    šŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. šŸ“ŠšŸ“ˆšŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ā¤ļø Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.