mlavin / django-moderation Goto Github PK

Having all the documentation in the README is not very readable.

https://github.com/mlavin/django-moderation/blob/master/src/moderation/fields.py#L42

Problematic code:

    def _serialize(self, value):
        if not value:
            return ''

        value_set = [value]
        if value._meta.parents:
            value_set += [getattr(value, f.name)
                          for f in value._meta.parents.values()]

        return serializers.serialize(self.serialize_format, value_set)

If the model is a proxy then parents will be a dictionary like {ParentModel: None} and this will raise an AttributeError because None does not have a name attribute. Should be straight forward to check if this is a proxy and handle this case correctly.

Probably more of my personal preference by tox is infinitely better than the current buildout setup.

Users may want to approve/reject groups of related object changes together. The moderation registration should allow following related models.