ml-explore / mlx-c Goto Github PK

View Code? Open in Web Editor NEW

50.0 50.0 11.0 4.02 MB

C API for MLX

Home Page: https://ml-explore.github.io/mlx-c

License: MIT License

C++ 55.34% C 30.93% Python 11.28% CMake 2.46%

mlx

mlx-c's Issues

missing functions from ops.h

I noticed that these are missing from ops.h:

/**
 * Extract the number of elements along some axes as a scalar array. Used to
 * allow shape dependent shapeless compilation (pun intended).
 */
array number_of_elements(
    const array& a,
    std::vector<int> axes,
    bool inverted,
    Dtype dtype = int32,
    StreamOrDevice s = {});

/** Bitwise and. */
array bitwise_and(const array& a, const array& b, StreamOrDevice s = {});
array operator&(const array& a, const array& b);

/** Bitwise inclusive or. */
array bitwise_or(const array& a, const array& b, StreamOrDevice s = {});
array operator|(const array& a, const array& b);

/** Bitwise exclusive or. */
array bitwise_xor(const array& a, const array& b, StreamOrDevice s = {});
array operator^(const array& a, const array& b);

/** Shift bits to the left. */
array left_shift(const array& a, const array& b, StreamOrDevice s = {});
array operator<<(const array& a, const array& b);

/** Shift bits to the right. */
array right_shift(const array& a, const array& b, StreamOrDevice s = {});
array operator>>(const array& a, const array& b);

I am not sure about number_of_elements() but the bitwise and arithmetic shift functions should be added.

mlx_compile does not work in C

Here is reproduce code snippet:

#include <stdio.h>
#include <stdlib.h>

#include "mlx/c/mlx.h"

mlx_array inc_fun(mlx_array in) {
  mlx_array y = mlx_array_from_float(1.0);
  mlx_array res = mlx_add(in, y, MLX_GPU_STREAM);
  mlx_free(y);
  return res;
}

int main() {
  mlx_closure cls = mlx_closure_new_unary(inc_fun);

  // jvp
  {
    mlx_enable_compile();
    printf("start compile:\n");
    mlx_compile(cls, true);
    printf("end compile:\n");
  }

    return 0;
}

result:
libc++abi: terminating due to uncaught exception of type std::invalid_argument: [compile] Cannot compile a non-addressable function.

this is where it throws exception

Exception in libc++api

I'm working on some bindings that make use of mlx-c but I'm finding that if I run tests that create arrays right after having previously ran tests i'm getting an error:

libc++abi: terminating due to uncaught exception of type std::__1::system_error: condition_variable wait failed: Invalid argument

My guess is some kind of threadpool issue, is there a way to specify limits? Could this be an error in mlx-c?

missed function

While going back and catching older mlx functions that got missed while building, I ran across

array tensordot(
    const array& a,
    const array& b,
    const std::pair<std::vector<int>, std::vector<int>>& dims,
    StreamOrDevice s /* = {} */

The unusual signature isn't in mlx-c (the normal one with a single int is present).

please expose buffer cache controls

Specifically:

https://github.com/ml-explore/mlx/pull/390/files#diff-2af536d53a1f373bb55d5874fce6a65d02749359df0d4402cbc3129d457ab3d0

bool cache_enabled(void);
void set_cache_enabled(bool enabled);

This is useful in controlling memory use in resource constrained environments.

Planned release cadence?

What is the planned release cadence for mlx-c? Will mlx-c follow the weekly release cadence of mlx?

ml-explore / mlx-c Goto Github PK

mlx-c's Issues

missing functions from ops.h

mlx_compile does not work in C

Exception in libc++api

missed function

please expose buffer cache controls

Planned release cadence?

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent