ml-archive / aws Goto Github PK

The supplied documentation for submitting to S3 does not reflect that of the S3 module.

i.e. init:
The documented:
S3( accessKey: "my-key", secretKey: "my-secret", region: "my-region", bucket: "my-s3-bucket")
The actual:
S3(host: "foo", accessKey: "bar", secretKey: "bar", region: .usWest2)

i.e. upload:
The documented:
.uploadFile("/path/to/local/file", "/folder/in/s3/bucket")

The actual:
upload(bytes: [UInt8(1)], path: "f", access: .authenticatedRead)

Im receiving Socket failed with code 0 ("Success") [ipAddressValidationFailed("Name or service not known")]

let s3 = S3(host:"bucket.s3.amazonaws.com", accessKey: accessKey, secretKey: secretKey, region: .usEast1)
try s3.upload(bytes:file.part.body, path:filePath, access:.privateAccess)

I kept running into issues with the signature not matching the one generated by AWS. The problem turned out to be missing headers passed to the sign function. This resolved the issue:

var signedHeaders = try signer.sign(payload: Payload.bytes(parameterString.bytes), method: .post, path: "/", headers: ["content-type": "application/x-www-form-urlencoded; charset=utf-8"])
signedHeaders[.contentType] = "application/x-www-form-urlencoded; charset=utf-8" // solved issue

I think the sign function should return the headers that are passed to it. What do you guys think?

Required tests to be fully compliant:

Get

• Unreserved
• UTF-8
• Vanilla
• Vanilla query
• Vanilla empty query key
• Vanilla query unreserved
• Vanilla UTF-8 query

Post

• Vanilla
• Vanilla empty query value
• Vanilla query non unreserved

Normalize path^**

• Normalize path
• Get relative
• Get relative relative
• Get slash
• Get slash dot slash
• Get slash pointless dot
• Get slashes
• Get spaces

Note: There are more test cases, but they don't pertain to us as they're testing valid key/values for queries.

**: These tests don't apply to S3 signing; an S3 url should not be normalized.

Thanks for this lib!

Can this library be used to develop ios apps?

Thank You.

Query should be a dictionary type not a string. Query keys need to be sorted and checked for duplicates.

Get

• Header key case
• Header key sort

Post

• Header key case
• Header key sort
• Header value case

Replace all external cURL calls with vapor/engine's BasicClient

Hallo I had tried out the package and the upload works for me. But now for my full use case I have to delete the uploaded blobs and I saw in the code that there is no delete function. So my questions is Does someone work on this? I saw you are open for PRs, but first I would like to know if somebody works on this?

https://github.com/nodes-vapor/aws/blob/b629456e01ff260b8c9292a8a532f9eac37bed46/Sources/S3/S3.swift#L74

Add support for AWS STS temporary security credentials

Amazon Version 4 Test Suite tests

Post

• STS token

Shouldn't we be able to use the Region enum, as it's marked as public?

Is it coming?

Submit to PR allowing client to opt out of percent encoding. Clients encoder isn't as sensitive as amazon requires so it causes problems with spaces and dashes.

Trying to build a project that includes this package throws this error:

Cloning https://github.com/nodes-vapor/aws.git
error: The dependency graph could not be satisfied. The package (https://github.com/nodes-vapor/aws.git) with version tag in range (1.0.0..<1.9223372036854775807.9223372036854775807) is not found. Found tags ([0.0.0, 0.1.0])