mkortkamp / kmlframework Goto Github PK

A bug is present in the current implementation: Feature.setVisability()
is misspelled, correct is setVisibility().
The resulting KML contains the invalid, misspelled tag.

[deleted issue]

What steps will reproduce the problem?
1. class: Link.java
   package: org.boehn.kmlframework.kml
   method: writeInner(Kml kml)

   delete one of this if blocks:
   if (refreshInterval != null) { ... }

maybe a copy-paste error...

cheers tobi

Class BallonStyle has a wrong name (missing an o).

Correct name should be BalloonStyle and its KML tags be written as 
<BalloonStyle> </BalloonStyle>

Steps to reproduce the problem:
1. Create a new Kml.
2. Add a Folder to the Kml.
3. Add a Folder (with anything inside) to the previously added Folder.
4. Write Kml to file.

Seen result: Writing to file fails.
Expected result: Writing to file works (since it works in Google earth 
5.0) or an exception is raised when adding the Folder to another Folder 
(if it is not valid in KML).

KmlFramework version: 2009-03-20 (jar)
System: JDK 1.6 (XP SP3)

What steps will reproduce the problem?
1. no steps required. it is a spelling error.

What is the expected output? What do you see instead?
expected is the creation of a <visibility> tag. instead it is named
<visablity> (like the method to set it), and therefore the tag is
ignored/not recognized.

What version of the product are you using? On what operating system?
version 20090130, gentoo linux, jdk 1.6.0.11

Quickfix:
in org.boehn.kmframework.kml.Feature.class replace

kml.println("<visability>" + booleanToInt(visability) + "</visability>");

with

kml.println("<visibility>" + booleanToInt(visability) + "</visibility>");

This will at least fix functionality, but the spelling error should be
corrected everywhere.

Regards,
Daniel.

What steps will reproduce the problem?
1. Run the SimpleExample and investigate the output

What is the expected output?
<Document>
<Placemark>
somethings inside
</Placemark>
</Document>

What do you see instead?
<Document>
<Placemark>
somethings inside
</Placemark>
<Placemark>
somethings inside
</Placemark>
</Document>

Kml kml = new Kml();
Document doc = new Document();
kml.setFeature(doc);
Placemark pt = new Placemark("<hi there>");
doc.addFeature(pt);
kml.createKml("/tmp/bad.xml");

Text that is put into xml needs to be escaped into &lt;hi there&gt;

What steps will reproduce the problem?
1. Create any simple kml, at least one object id must start with a 0-9.
2. Try to validate your kml.

Using UUID.randomUUID() creates random id that can start with either a
letter a-z or a figure 0-9.
When starting with a 0-9, this doesn't follow the standard and validation
fails.

Tested in http://kmlvalidator.com/home.htm and in google maps .

workaround: I edited your cKmlObject source and changed the id generation to :
"id"+UUID.randomUUID()

thanks,
JB

Current Region writes malformed xml. Added ending tags to LatLonAltBox and Lod

What steps will reproduce the problem?
1. Generate new Folder with name
2. Write the kml out
3. Open kml in Google Earth

What is the expected output? What do you see instead?
KML elements such as name are missing

What version of the product are you using? On what operating system?
org.boehn.kmlframework_20080721.jar on Linux using JDK 1.6

Please provide any additional information below.
Fix for the issue is to add super.writeInner(kml) call to
org.boehn.kmlframework.kml.Container.writeInner(Kml) method.
Attached is a fixed version of Container.java

I am using version: org.boehn.kmlframework_20090718.zip      
Version 20090718

I am using the Region Object.
The Output kml that is produced is not well formed:
1. The <LatLonAltBox> tag is missing a / in the closing tag.
2. The <Lod> tag is missing a / in the closing tag.
3. <minFadeExtent> tag is generated twice.

<Region>
<LatLonAltBox>
<north>50.9002644390218</north>
<south>50.90008425591732</south>
<east>4.354273054052638</east>
<west>4.354093390995808</west>
<LatLonAltBox>
<minAltitude>0.0</minAltitude>
<maxAltitude>0.0</maxAltitude>
<Lod>
<minLodPixels>-1.0</minLodPixels>
<maxLodPixels>-1.0</maxLodPixels>
<minFadeExtent>-1.0</minFadeExtent>
<minFadeExtent>-1.0</minFadeExtent>
<maxFadeExtent>-1.0</maxFadeExtent>
<Lod>
</Region>

Thanks
Asaf B.