mkobuolys / flutter-design-patterns Goto Github PK

https://github.com/mkobuolys/flutter-design-patterns/blob/66707f0cfbba37da360b3b470d833c17a0062a84/lib/design_patterns/facade/facades/smart_home_facade.dart#L56C1-L56C1

hi, first of all, I want to thank you for your amazing repo,

I just noticed that in the referenced function (stopStreaming) you turned the lights On which is already on, based on your previous function (startStreaming), and is there any reason to add turnLightsOn() again?

thank you in advance for your clarification

void startStreaming(SmartHomeState smartHomeState) {
smartHomeState.lightsOn = smartHomeApi.turnLightsOn();
smartHomeState.tvOn = tvApi.turnOn();
gamingFacade.startStreaming(smartHomeState);
}

void stopStreaming(SmartHomeState smartHomeState) {
gamingFacade.stopStreaming(smartHomeState);
smartHomeState.tvOn = tvApi.turnOff();
smartHomeState.lightsOn = smartHomeApi.turnLightsOn();
}

can i publish your work(app) in playstore? i like to study when travelling. by the way awesome work.

Good work!

build failed running in ios

** BUILD FAILED **
Xcode's output:
↳
: Error: No named parameter with the name 'builder'.
lib/navigation/router.gr.dart:20
builder: (_) {
^^^^^^^
: Context: Found this candidate, but the arguments don't match.
../…/router/auto_route_page.dart:64
MaterialPageX({
^^^^^^^^^^^^^
: Error: No named parameter with the name 'builder'.
lib/navigation/router.gr.dart:25
builder: (data) {
^^^^^^^
: Context: Found this candidate, but the arguments don't match.
../…/router/auto_route_page.dart:64
MaterialPageX({
^^^^^^^^^^^^^
Failed to package /Users/kanakapallianurag/Downloads/flutter-design-patterns-master.
Command PhaseScriptExecution failed with a nonzero exit code

StreamController.broadcast() seems redundant, maybe try to modify it to StreamController().

Although it looks like the ObserverExample uses the stockStream.listen() twice, but since the two StreamControllers are different, So there will be no error exception, it may not be necessary to use StreamController.broadcast().

Whatever code I select, I can't see if it is selected or not.

The first code block I actually selected.
The second, I didn't.

Maybe add a color to SelectableText widget.

When I deploy the App for flutter web the Back-Buttons not working anywhere in the App.

Tried to build apk.

[INFO] Generating build script...
[INFO] Generating build script completed, took 1.1s

[INFO] Initializing inputs
[INFO] Reading cached asset graph...
[INFO] Reading cached asset graph completed, took 423ms

[INFO] Checking for updates since last build...
[INFO] Checking for updates since last build completed, took 2.0s

[INFO] Running build...
[INFO] Running build completed, took 75ms

[INFO] Caching finalized dependency graph...
[INFO] Caching finalized dependency graph completed, took 294ms

[INFO] Succeeded after 410ms with 0 outputs (0 actions)

PS C:\Users\haris\OneDrive\Documents\My Repo\flutter-design-patterns> flutter build apk --split-per-abi 

💪 Building with sound null safety 💪

/C:/FlutterSDK/flutter/.pub-cache/hosted/pub.dartlang.org/auto_route-2.4.2/lib/src/router/provider/auto_route_information_provider.dart:28:8: Error: The method 'AutoRouteInformationProvider.routerReportsNewRouteInformation' doesn't have the named parameter 'type' of overridden method 'RouteInformationProvider.routerReportsNewRouteInformation'.
  void routerReportsNewRouteInformation(RouteInformation routeInformation,
       ^
/C:/FlutterSDK/flutter/packages/flutter/lib/src/widgets/router.dart:1329:8: Context: This is the overridden method ('routerReportsNewRouteInformation').
  void routerReportsNewRouteInformation(RouteInformation routeInformation, {required RouteInformationReportingType type}) {}
  ^^^^^^^^^^^^^
/C:/FlutterSDK/flutter/.pub-cache/hosted/pub.dartlang.org/auto_route-2.4.2/lib/src/router/delegate/auto_router_delegate.dart:43:43: Error: Required named parameter 'type' must be provided.
        ?.routerReportsNewRouteInformation(
                                          ^


FAILURE: Build failed with an exception.

* Where:
Script 'C:\FlutterSDK\flutter\packages\flutter_tools\gradle\flutter.gradle' line: 1070

* What went wrong:
Execution failed for task ':app:compileFlutterBuildRelease'.
> Process 'command 'C:\FlutterSDK\flutter\bin\flutter.bat'' finished with non-zero exit value 1

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.

* Get more help at https://help.gradle.org

BUILD FAILED in 39s
Running Gradle task 'assembleRelease'...                           41.3s
Gradle task assembleRelease failed with exit code 1```

https://github.com/mkobuolys/flutter-design-patterns/blob/04514284d1e1a55241e3b3a5bd40533ed5ba6f2f/lib/design_patterns/visitor/file.dart#L7C45-L7C45

Hi , thanks for your amazing and inspiring repo,
I just found that in this File class, you didn't implement the 'accept' method of the iFile interface despite that you have used 'implement' keyword here

It would be nice to zoom images provided in the markdown files of the design patterns.

This feature is already implemented with #24, but due to changes in the codebase and migration to Dart null-safety the code is already outdated and this solution should be reworked.

Sample CI:
https://github.com/prateekmedia/flutube/blob/main/.github/workflows/generate_apk.yml

• Address #43

Currently using flutter_windows_2.10.1-stable.

Build failed due to use of deprecated Android v1 embedding.

You can try to delete android:name="io.flutter.app.FlutterApplication".

Trying to install app by instructions in readme: