Code Monkey home page Code Monkey logo

videojs-share's People

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar

videojs-share's Issues

fb and messenger does not seem to work.

This is a really nice plugin to begin with! but aparently facebook and messenger does not appear in share panel. I have provided fbAppId parameter as well.
Could you please help me with this?Here is my code:

         var shareOptions = {
                socials: ['fb', 'tw', 'messenger'/*, 'reddit', 'gp', 'messenger', 'linkedin', 'telegram', 'whatsapp', 
                'viber', 'vk', 'ok', 'mail'*/],
                url: window.location.href,
                title: "@Umbraco.Field("pageTitle", altFieldAlias: "pageName")",
                description: "@Umbraco.Field("pageTitle", altFieldAlias: "pageName")",
                image: "@Umbraco.Field("primaryImage")",

                // required for Facebook and Messenger
                fbAppId: 'myAppId',
            }

            player.share(shareOptions);

Facebook share button

Hi, I am trying to implement share plugin into my player, but I have a problem with facebook. All the buttons show up, except Facebook. I added fbAppId and nothing happens.

Thank you,
Marko.

Facebook share not working for external embeds

Received this error when the player is embedded in other domains:

Warning
Can't Load URL: The domain of this URL isn't included in the app's domains. To be able to load this URL, add all domains and subdomains of your app to the App Domains field in your app settings.

Works fine for all other social share. Any ideas on how to resolve this? Also, anyway to prevent a page refresh when pop-up for share shows up?

fb example not updated

The example on the readme puts "fb" in the options when it should be "fbFeed".
Also, when I press the fbFeed button the window that opens up starts sliding to the side on its own, not really an error but weird. (Using google chrome on a linux machine)

.vjs-share is applied to the entire player

Discussed further in iv-org/invidious#160.

Fanboy's Social Blocking and Fanboy's Annoyance List block the class .vjs-share.

This class is applied to the entire video frame here, along with .vjs-videojs-share:

this.player.ready(() => {
this.player.addClass('vjs-share');
player.addClass('vjs-videojs-share');
player.getChild('controlBar').addChild('ShareButton', options);
player.addChild('ShareOverlay', options);
});

But later you only make use of .vjs-videojs-share on the frame, while using .vjs-share for the button.

And thus the entire player is blocked, instead of only the share button.

Clicking on Close (x) icon throws a JS error in the console

When you click on the Close (x) icon, it throws the following JS error:

video.js:498 VIDEOJS: ERROR: TypeError: Cannot read property 'trigger' of null
    at e.close (videojs-share.min.js:7)
    at CloseButton.bound (video.js:2348)
    at HTMLButtonElement.bound (video.js:2348)
    at HTMLButtonElement.data.dispatcher (video.js:1971)
    at trigger (video.js:2103)
    at CloseButton.trigger$$1 [as trigger] (video.js:2964)
    at CloseButton.handleClick (video.js:12956)
    at HTMLButtonElement.bound (video.js:2348)
    at HTMLButtonElement.data.dispatcher (video.js:1971)

No "fbButton" support?

This plugin appears to support "fbFeed" but not "fbButton". Am I missing something?

I need fbButton as it allows sharing without the domain restrictions that the other Facebook sharing options have (where appid must explicitly allow all domains in use).

Thanks!

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.