mjhoskin / mpident Goto Github PK

Web scraped wikipedia data in ethnicity.py should be merged into primary characteristic table on name.

When the tool is run in scrape mode and new MPs are found, they need to be appended to the Characteristic data, and flagged for manual insertion of key characteristics.

Once MP data collated and joined, need to decide upon and build logic for filtering based on conditions.

For hair, beard, changeable features:

• provide people with matching
• then people with different at bottom

Black - request Brown next
Brown - request Grey next, then black
Grey - request brown next
Short - request No hair (only m), then medium hair
Medium - request long

Beard - Stubble - Goatee

Glasses - no glasses

Should include instructions for initial use, and caveats around characteristics, as well as guidance on issue raising if people have differing views on user definable characteristics where definition is not explicitly quantifiable.

Currently image scraping file (get_images.py) is a standalone script. Connecting to the full loop will make accessibility easier.

Add docstrings, logging etc as needed.

Unit test status is currently severely lacking.

Break methods into specific .py files for various tasks.

E.G. a characteristics.py file, a json.py file.

For styling purposes, precommits would be useful to setup.