mjg / quotecollapse Goto Github PK

Thunderbird 60 has enabled strict compaibility, meaning the addon needs to be marked compatible at AMO for it to work in Thunderbird 60. I have tested TB60 with strict compaibility FALSE and quotecollapse works, so marking compatible might be the only change needed. If not, then please consult https://wiki.mozilla.org/Thunderbird/Add-ons_Guide_57

BTW, I love QC!

The Add-On is loaded in the version but does not work.
Thanks.

Hello everybody,
I recently had quotations that begun with an URL.
As the link begins just next to the + sign that allows to expand the quotation, I have to be very precise with the mouse, to be able to click on the + without clicking on the link.
So, as my precision was a little just, I opened the linked page without wanting to do so.

I presume a little margin around the + could help to manage that situation ?

It would be nice if there was an option to only collapse n-th level quotes and those below.

I'm reading a few mailing lists where people use the interleaved reply style extensively. It would be nice to have the first level of quotation uncollapsed, so that you know what the reply is about, and everything below that collapsed to save you a lot of scrolling.

I reported a bug with bugzilla (#1465084), but it turned out that QuoteCollapse was the cause.

Thunderbrd 52.7.0 on Ubuntu 16.04, QuoteCollapse 1.0, using customisation from the official page to have all quotes expanded by default (first example on the page, used as is, without any editing). Without the customization the bellow problem does not occur.

When:

• a message contains nested quotes and
• I let collapse the inner one, it's parent quote also collapses*), but if then
• I expand the parent one again and
• I want to expand the child,

it does NOT expand and makes the parent collapse back instead.

*Note: Apparently this works as intended in the code, although I am not particularly excited about this feature either.

The problem is probably at the lines 90–91 of quotecollapse.js (I do not understand the logic there, i.e. why only the false value of qctoggled may be returned and true should be ignored, but I didn't really analyse it). When I simplify it like this it works OK for me.

90,91c90,91
<       if(current.nodeName == "BLOCKQUOTE" && current.getAttribute("qctoggled") != "true")
<         return false;
---
>       if(current.nodeName == "BLOCKQUOTE")
>         return current.getAttribute("qctoggled") == "true";

Upgraded to Thunderbird 52.7.0 today (Kubuntu 17.10, 64-bit), and Quote Collapse is mangling messages.

For example:

The message is a simple text/plain with a single layer of quoting:

To: Mark Nottingham <[email protected]>, HTTP Working Group <[email protected]>
Cc: Patrick McManus <[email protected]>
References: <[email protected]>
From: =?UTF-8?Q?Lo=c3=afc_Hoguin?= <[email protected]>
Organization: Nine Nines
Message-ID: <[email protected]>
Date: Tue, 3 Apr 2018 16:17:34 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.7.0
MIME-Version: 1.0
In-Reply-To: <[email protected]>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Subject: Re: Working Group Last Call: Bootstrapping WebSockets with HTTP/2
Archived-At: <https://www.w3.org/mid/[email protected]>
Resent-From: [email protected]
X-Mailing-List: <[email protected]> archive/latest/35227
X-Loop: [email protected]
Resent-Sender: [email protected]
Precedence: list
List-Id: <ietf-http-wg.w3.org>
List-Help: <https://www.w3.org/Mail/>
List-Post: <mailto:[email protected]>
List-Unsubscribe: <mailto:[email protected]?subject=unsubscribe>

On 03/28/2018 11:48 PM, Mark Nottingham wrote:
> Hi everyone,
> 
> Patrick (as editor) has incorporated the discussion from London and believes this is ready for WGLC; there are no open issues.
> 
> Please have a look at:
>    https://tools.ietf.org/html/draft-ietf-httpbis-h2-websockets-01
> 
> ... and bring up any issues on-list or on its issues list; likewise statements of support (or otherwise) for publication on-list would be appreciated.

Hello,

I am finalizing a server implementation. Just tried it against Chrome 
and things work as intended, with and without permessage-deflate.

I was a little surprised to see that the value for 
SETTINGS_ENABLE_CONNECT_PROTOCOL (0x8) is only defined in the IANA 
considerations.

I would +1 the need for some language on the END_STREAM flag, including 
how endpoints should behave when END_STREAM (or RST_STREAM) is sent on 
the stream without a close frame. I assume it's the same behavior as if 
an HTTP/1.1 Websocket connection was improperly closed but it would be 
nice to have confirmation.

Thanks for the great spec!

Cheers,

-- 
Loïc Hoguin
https://ninenines.eu

I transformed QuoteCollapse 1.1.1 to a legacy webextension version.
Thunderbird 68+ only, includes a toolbarbutton and a keybinding [q].

quotecollapse-2.0-tb.zip

In a long mail thread where users kept replying while adding to, and including the previous messages, quotecollpse takes minutes to handle the newest messages in the thread. Thunderbird is unresponsive for maybe 10 minutes at a time.

After upgrading Thunderbird to version 60.4, I am now seeing overlapping text, probably the same issue as issue #7. The fix in that issue says to modify the userContent.css file, especially if you had a customized one. However, I cannot find a userContent.css file anywhere in any directory related to Thunderbird, not in my profile directory, not in the Program files directory.

Oddly, I am only having the problem on a Windows 7 system that has had Thunderbird installed and upgraded over the years, but not running the same version of Thunderbird on a Windows 10 system that is less than a year old.

mozdev.org is gone and with it the styles etc.

Not being a lawyer, I am note sure whether I am allowed to use local copies.

Not being a web designer, I won't come up with a new desgin quickly, but this issue is a remainder to at least un-break the site.