mjfreelancing / alloverit Goto Github PK

At current, the DoubleExtensions class has a defined constant const double Epsilon = 1E-07.
I propose removing it to use the build-in double.Epsilon, then adding overloads to allow for custom variance, which seems to be the more modern approach in many other libraries.

This old post on StackOverflow describes that:

The System.Double type can represent values accurate to up to 15 digits. So a simple first order estimate if a double value x is equal to some constant is to use an epsilon of constant * 1E-15

Another post on the same thread suggests their own implementation, should you wish to keep a default variance:

/// <summary>
/// smallest such that 1.0+EpsilonD != 1.0
/// </summary>
public const double EpsilonD = 2.2204460492503131e-016;

Describe the bug
.NET uses the Options Pattern to provide configuration.

The D2ErdGenerator constructor requires an "ErdOptions" class. However, it does not accept an IOptions<ErdOptions> or similar. This means that it cannot be instantiated by dependency injection without hacks.

To Reproduce
Steps to reproduce the behavior:

• Add the AllOverIt.EntityFrameworkCore.Diagrams package.
• Use the default options: builder.Services.Configure<ErdOptions>(options => {});
• Register the service builder.Services.AddSingleton(D2ErdGenerator)();
• Add an endpoint app.MapGet("/DbDiagram", (D2ErdGenerator generator, MyDbContext dbContext) => generator.Generate(dbContext));

Expected behavior
The ERD string is generated.

** Actual behavior**
Crashes.

Additional context
This can be hacked around with the following: builder.Services.AddTransient( serviceProvider => serviceProvider.GetRequiredService<IOptions<ErdOptions>>().Value );