Comments (5)
Hi!
Thanks for your comment. I thought a lot about the naming of the class myself and came to the conclusion to change it into something more common. My current favorite name is Point :-)
from phpgeo.
Hi,
I just pushed the first commit to the 4.0 milestone. The Coordinate
class was renamed to Point
. I don't have a due date for this milestone yet, probably sometime later in 2020.
The 4.0 change log can be found here: https://github.com/mjaschen/phpgeo/blob/milestone/4.0/CHANGELOG.md
from phpgeo.
I see.. I definitely see a use for a Point class(as well as other shapes, such a Polyline and a Radius, for example), but I'd keep coordinates within those. jm2c ofc :)
Thanks for the quick reply! :)
from phpgeo.
Stellar library @mjaschen! 💪
Chiming in because I love these types of discussions because I always learn something.
@omissis: Thoughts on below?
Point(float $position)
PointPair(Point $latitude, Point $longitude)
Coordinate(PointPair $points, Ellipsoid $ellipsoid = null)
I'm 👎 for Coordinates
(plural) because that would imply a collection of Coordinate
objects (to me, anyway).
from phpgeo.
@bmeynell sorry to get to answer your question so late! I'd be more for Coordinates
as it's how someone would commonly use the term (think telling someone "tell me your coordinates": the result will be made of a latitude and a longitude). I understand the "Coordinates make me think of an array of Coordinate" kind of thinking, but I would dispute that's how (some/most) programmers think(so there's a clear bias): that's not necessarily bad(the library is for programmers after all), but it's not how the term is used in its original context.
from phpgeo.
Related Issues (20)
- Geofence from point HOT 1
- Polygon area calculation HOT 1
- It doesn't support multipolygon ? HOT 2
- Warning emitted for valid coordinates in CoordinateFactory HOT 2
- Feature: Simplify Polygon HOT 2
- "Longitude value must be numeric" bad exception HOT 4
- Library Use HOT 1
- Calculate cardinal direction distances between two coordinates HOT 2
- Division by zero in BearingEllipsoidal.php on line 206 HOT 5
- Find all objects within specific Distance HOT 2
- Add support for PHP 8.1
- Remove support for PHP 7.2
- Add deprecations for version 5.0
- PHP Fatal error: Uncaught Error: Class "Location\Coordinate" not found in ....
- Build errors in PHP 8.x
- Explanation of warning for non-geo wiz
- Point directions
- Point-to-line distance is incorrect sometimes HOT 6
- Merging multiple adjacent rectangles into one polygon
- Line::intersectsLine() is buggy HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from phpgeo.