Comments (3)
I'll have a look at this over the next days.
from phpgeo.
Added a test for this issue: master...fix/96
@nilshoerrmann It seems that there's a bug when checking for line intersection for some edge cases – do you have an idea for a fix/workaround?
from phpgeo.
From a quick look at the source, in intersectsLine()
we have these conditions:
// the lines are collinear or touch
if (
in_array(self::ORIENTATION_COLLINEAR, $orientation, true)
&& (new Intersection())->intersects($this, $line, false)
) {
return true;
}
This only works if all points are collinear but fails if this is only true for three points (as in the example). So we would either have to switch to high precision for all calculations – (new Intersection())->intersects($this, $line, true)
– or we would have to add a more precise condition that distinguises between three collinear points (setting precision to true
) and four collinear points (settings precision to false
).
from phpgeo.
Related Issues (20)
- Geofence from point HOT 1
- Polygon area calculation HOT 1
- Problem with calculating distance using Vincenty HOT 1
- Warning emitted for valid coordinates in CoordinateFactory HOT 2
- Feature: Simplify Polygon HOT 2
- "Longitude value must be numeric" bad exception HOT 4
- Library Use HOT 1
- Calculate cardinal direction distances between two coordinates HOT 2
- Division by zero in BearingEllipsoidal.php on line 206 HOT 5
- Find all objects within specific Distance HOT 2
- Add support for PHP 8.1
- Remove support for PHP 7.2
- Add deprecations for version 5.0
- PHP Fatal error: Uncaught Error: Class "Location\Coordinate" not found in ....
- Build errors in PHP 8.x
- Explanation of warning for non-geo wiz
- Point directions
- Point-to-line distance is incorrect sometimes HOT 6
- Merging multiple adjacent rectangles into one polygon
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from phpgeo.