Code Monkey home page Code Monkey logo

scorpcasestudy's Introduction

Scorp Case Study

Simple app that lists people which are fetched from mock network called PeopleDataSource.

Changes

There have been some changes on provided files. These changes are;

  • Person.kt was renamed as PersonResponse.kt to make it obvious that this class belongs to data layer.
  • DataSource was renamed as PeopleDataSource to make it more specific that it belongs to people.
  • FetchError used to have String. Now it has Throwable, to be able to make error messages more user friendly/localized.

APK

To install the app, .apk can be found in ScorpCaseStudy/app-debug.apk. It is an unsigned apk (signed with debug key).

Tests

There is only one test class called GetPeopleUseCaseTest which tests GetPeopleUseCaseImpl class.

Dependency Graph

Dependency graph

Known issues

When PeopleFragment is launched, it fetches item list once, then checks if listed items are longer than the RecyclerView. If not, it fetches another item list. This causes an UI issue.

Solution would be to calculate ViewHolder and RecyclerView heights and find min item count should be fetched before updating the UI.

scorpcasestudy's People

Contributors

mitsinsar avatar

Watchers

 avatar

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.