mitodl / library Goto Github PK

Context (Environment)

When you hit the /logout URL, you are met with a 500 page. Need a page that we can send users to that is not behind auth to gracefully logout to. The logout URL is not exposed anywhere, but if someone types it out, they will get an error, but still logged out... then back in because they're sent back to the app.

Expected Behavior

Log out logs the user out and does not error.

Actual Behavior

Log out kicks you to a 500 page... then to the app... which logs you back in.

To Reproduce

type /logout in browser

Possible Solution

Create a new page, not authed, where we can send not logged in users to.

Loading the homepage, throws the following error in the Heroku app log:

2021-02-25T13:41:30.991870+00:00 app[web.1]: error: Serving an error page for /reading-history/teams.json?limit=5 2021-02-25T13:41:30.991882+00:00 app[web.1]: { message: '7 PERMISSION_DENIED: Missing or insufficient permissions.', 2021-02-25T13:41:30.991884+00:00 app[web.1]: stack: 2021-02-25T13:41:30.991886+00:00 app[web.1]: 'Error: 7 PERMISSION_DENIED: Missing or insufficient permissions.\n at Object.callErrorFromStatus (/app/node_modules/google-gax/node_modules/@grpc/grpc-js/build/src/call.js:30:26)\n at Http2CallStream.call.on (/app/node_modules/google-gax/node_modules/@grpc/grpc-js/build/src/client.js:96:33)\n at Http2CallStream.emit (events.js:203:15)\n at process.nextTick (/app/node_modules/google-gax/node_modules/@grpc/grpc-js/build/src/call-stream.js:100:22)\n at process._tickCallback (internal/process/next_tick.js:61:11)', 2021-02-25T13:41:30.991887+00:00 app[web.1]: code: 7, 2021-02-25T13:41:30.991888+00:00 app[web.1]: details: 'Missing or insufficient permissions.', 2021-02-25T13:41:30.991889+00:00 app[web.1]: metadata: { internalRepr: {}, options: {} }, 2021-02-25T13:41:30.991890+00:00 app[web.1]: note: 2021-02-25T13:41:30.991890+00:00 app[web.1]: 'Exception occurred in retry method that was not classified as transient' }

When tailing the Heroku app logs, noticed the warning below with several folder names and figured something worth understanding at this early stage:

warn: Folder QA contains duplicate resources with slug

Steps required to deploy app in a production environment:

• Request new Google Drive from IS&T
• Setup Heroku pipeline
• Add RC app
• Fork nytimes/library-customization repository to use for overriding some behavior
• Look into triggering automatic build when commits happen on forked library-customization repo

Problem Description

Our SAML implementation does not use the config file as we ran into issues getting that stood up. Now that we have RC and prod working, we should attempt to go back and refactor out anything specific to us, but leave the generic SAML strategy in to later push upstream.

Feature

A generic SAML strategy will be added as a third auth option.

Additional Information

See the information on customization repo and the customization repo example for more information.