Code Monkey home page Code Monkey logo

unofficial-jisho-api's People

Contributors

damien-mcmahon avatar dependabot[bot] avatar gyn7561 avatar h7x4 avatar mistval avatar nonemoticoner avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar

unofficial-jisho-api's Issues

Word Type Search

On jisho.org, it is possible to see the 'type' of word, for example, suru verb, godan verb etc. In the future would it be possible to get that information via the unofficial jisho api? I also now Jisho has a lot of information about inflection, being able to get that information would be super cool too.

Undefined <result.strokeOrderSvgUri>

First, thank you for making this API project.
Second, when I use your API to print result.strokeOrderSvgUri what I get is Undefined and the trouble is in the animationUri link in the index.js file.
I hope you can update it with a new link, thank you.

Errors in parsing furigana

I'm going to maintain a list of queries here for which the parser does not do the right thing.

seldom (first example sentence)
(first example sentence, 々 appears in kana)

CORS

Hi, first of all thanks for making this great tool! This is exactly what I was hoping to find.

I'm getting the cross origin error when I try to use this though (and I saw it was discussed in the thread on jisho). Is there anyway to send the requests through a proxy?

Stroke order animation

Firstly, thank you for the awesome api. I'm using it in my personal project.
Secondly, I was wondering if it would be possible to get the stroke animation or should I just directly use the kanjiVG for that?

sameSite attribute issue

I'm getting this "issue" on the console,
Indicate whether to send a cookie in a cross-site request by specifying its SameSite attribute
while working with this API.
and because of this, I cant make multiple requests with this API. I tried resolving it on client side but didn't found any promising solution.

reading of jukugo

I'd like get the reading of a jukugo.
The following provides meaning but not the reading.
How can one achieve this?

jisho.scrapeForPhrase('電車').then((data) => {
  console.log(JSON.stringify(data, null, 2));
});

Example sentence for word scrape senses occasionally misses pieces

Jisho seems to sometimes not wrap details like symbols (parens, punctuation, etc.), katakana names and sometimes even words in a <li class="clearfix"> tag. This means that the parser will skip over them.

An example search is 赤い which will yield the sentence

ヘレンはみんなにほめられて顔を赤くした

Formatted as

<ul class="japanese japanese_gothic clearfix" lang="ja">
    ヘレン
    <li class="clearfix"><span class="unlinked"></span></li>
    <li class="clearfix"><span class="unlinked">みんな</span></li>
    <li class="clearfix"><span class="unlinked"></span></li>
    <li class="clearfix"><span class="unlinked">ほめられて</span></li>
    <li class="clearfix"><span class="furigana">かお</span><span class="unlinked"></span></li>
    <li class="clearfix"><span class="unlinked"></span></li>
    <li class="clearfix"><span class="furigana">あか</span><span class="unlinked">赤く</span></li>
    <li class="clearfix"><span class="unlinked">した</span></li><li class="english" lang="en">Helen blushed at their praise.</li>
</ul>

which makes the parser miss ヘレン and

Some other searches are かな, たら (Particle 2, this one even has kanji missing furigana outside clearfix) and .

Attempting to import this project into my React Native Project

I do not know what details to provide, but I am having an extremely hard time importing the project in my App. I went through the normally NPM install unofficial-jisho-api. Attempted to import the project by typing in import jisho from 'unofficial-jisho-api';

My project fails each and every time. I deleted the node modules and then did an npm install and still did not resolve my issue. Any help will be greatly appreciated.

Enable Option for CORS

It would be a good idea to create a option to add a url of a CORS reverse proxy server infront of the jisho url. That would enable this api to also work on browser-side applications.

Make searchForPhrase independent of Jisho API

I suggest to drop being dependent upon Jisho API for word search. Two reasons:

  1. Official Jisho API does not provide all the data in its word/phrase endpoint e.g. information about JLPT level is missing.
  2. searchForPhrase method is just routing data from Jisho API and anyone could make a simple fetch call. So its usefulness in current version is a bit questionable.

Btw. very useful repo ;)

Associate furigana with phrases in searchForExamples

I was looking at this feature and immediately spotted what is lacking or what would be great to have.

What we currently get is this:

今日はとても暑い
きょうはとてもあつい
It is very hot today.

From above you can't tell (at least not immediately and in more complex sentances you for sure gonna run in troubles) which kana is associated with which phrase written in kanjis. But on Jisho this is visible:
https://jisho.org/sentences/5186634ed5dda7e981000029

I assume this would likely require implementation of new method i.e. scrapForExamples but I didn't investigate much so might be wrong.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.