minigugus / connect-postgres-simple Goto Github PK

Hey there,

just got around to trying this out, took a bit longer than anticipated ^^

Anyway, I struggled quite a bit at first because I trusted in the createTableIfMissing option to create the table, but it never did that.
This resulted in errors, which weren't really shown (probably because express-session only shows them in debug mode, which is odd). I had to manually add debug logging to access the error.

Maybe you could add some warnings if the table doesn't exists, etc.? (And fix the option, naturally 😉)

Hey @Minigugus, is there a possibility that you might update this to work properly with the latest version of Postgres.js (currently v3.3.2 as I write this)?

Here are a couple of the problems I ran into, which I've solved myself temporarily by manually altering /dist/index.js, but I'd rather my project depend on a properly updated version of this npm package instead of my patch branch:

1. createTableIfMissing throws an UNSAFE_TRANSACTION error since sql.begin is now required for transactions. I worked around this by manually creating the table myself.
2. I resolved a couple of instances of the following error by updating Date instances to strings with .toISOString():

   The "string" argument must be of type string or an instance of Buffer or ArrayBuffer. Received an instance of Date

I'm not sure if there are any other issues but it appears to be working well for me now with the above workarounds. Let me know if you have any plans of officially updating this to work with v3. Thanks!