minekube / gate Goto Github PK

We can now use the net.ErrClosing error instead of error string checking since Go 1.16.
golang/go#4373 (comment)

Evaluate whether use of https://github.com/google/gopacket further improves packet layer en-/decoding.

I was testing this proxy implementation when I discover something strange. The server connection gets frozen when you change your game mode.

I have tested this issue with Survival to Creative and Creative to Survival.

How to replicate:

• Clone this repository
• Start the extension example with the example servers
• Connect yourself to the server
• Execute de /gamemode creative {username} command.

You will see everything frozen and the player bar will appear like you are in survival mode.
You will be able to fly but not even open the inventory (since it is in survival mode)

In a few seconds, you will get kicked by timeout

I tried to make a command with alot of aliases such as:

1. /hub
2. /l
3. /lobby

But, it looks like there's no way to introduce aliases in one command. (Maybe I didn't understand in docs)
How could I do this?

Use https://developers.cloudflare.com/docs-engine/

Called multiple times could cause bug with.

When listening to events, it would be useful to send have access to the *minecraftConn object to send arbitrary packets.

To allow for this, I propose exporting connectedPlayer to ConnectedPlayer so someone writing a plugin can cast:

player, ok := e.Player().(*proxy.ConnectedPlayer)
if ok {
	player.WritePacket( /* some packet */ )
}

I can make a PR if this looks good.

To measure and debug and collect metrics on Gate, however, the deployment looks like, we should support tracing and metrics using https://opentelemetry.io/ SDK such that other tooling like Grafana Tempo, Prometheus, Jaeger, etc. can receive data from a running Gate process. This will help users to gain more visibility into their Gate deployment, measure and help fix latency issues, track player sessions over time, ...

Users can also opt in to anonymous data collection to help us understand usage and performance bottlenecks.

https://github.com/minekube/gate/blob/master/pkg/edition/java/proxy/session_backend_login.go#L135

This issue was reported on the Discord by ash

This issue is for discussion about Bedrock edition support and other future plans.

For development for bringing full Bedrock edition support to the Gate proxy please see the bedrock branch for all changes and feel free to comment your thoughts here and/or if you want to contribute!

Other plans:

• Distant future? A proxy for Java & Bedrock edition to mix and match players & servers of all kinds.
  (protocol translation back and forth...)

• Players can always join and will never be kicked if there is
  no available server to connect to, or the network is too full.
  Instead, players will be moved to an empty virtual room simulated
  by the proxy to queue players to wait.

I have two suggestions regarding the logging of the Gate proxy:

• It would be nice to have the possibility to choose what we want in the logs. For example, in production I don't think the path of the file and the line from which the logger was called is any useful information. Maybe the ability to choose the format of the date would be interesting too, for instance if we want to be able to process the logs with an other application... which leads us to the second point.
• Save the logs to a file, like any regular Minecraft proxy or server. For now, the only way I found to do that is to redirect manually the program outputs to a file like so: ./gate > logs.txt 2>&1, but color codes are not supported and render like this: �[34m.

Thanks for your reading

Further improve the existing algorithm for redirecting players to available servers (match protocol versions, mark unresponsive servers, don't retry moving a player to previously failed connections), and add API to add and remove try/fallback servers.

It stuck at the middle of fml hand shacking. I found there is a deadlock.
The gate is waiting for join server packet then will report SuccessConnectionStatus result to loginSessionHandler and turn to newInitialConnectSessionHandler to deal next client packet and forward to server.
but the fml handshacking isn't finish yet,and need client proxy to pass the fml handshacking packet to server to complete the fml handshacking.but proxy side still wait for result.

Forge Version: 1.12.2 14.23.5.2855

I'm curious,is there few people setup with forge server?

This issue is there to discuss the support for scripting languages in Gate.

To simplify and accelerate customization Gate should add support for popular scripting languages like:

• Lua (with this lib)
• Tengo

Which language should we target first?

Specifically Lua has being requested under Gate's reddit post.
Please up-vote this issue whether this scripting should be added and/or comment some thoughts on this.

What is the bug:

When the player is switching between different servers some chunk errors (just Client Side) can happen:

When the player is coming near the chunks these will disappear, but it is still a little bit annoying.

These are the chunks that are from the previous world the player was in.

This is especially the case with entities as they are just standing there as if nothing happened and the player cannot interact with them:

Setup:

It was not tested in other setups so here is the setup:

It is the examples/simple-network but with the modification that the servers are 1.17.1 paper servers and not 1.16 paper server.

Tested versions:

• Server:
  • Two paper-1.17.1-333 servers
  • gate_0.14.1_windows_amd64.exe
• Client:
  • Optifine 1.17.1
  • Minecraft 1.17.1 (So that nobody can say that it is an Optifine Bug)

This was tested on Windows.

Footnote

I hope this helps a little bit and if I have overlooked another issue with the same topic you can close it 😄.

I was testing this proxy implementation when I discover something strange. I get an Internal server connection when I make myself a server operator.

Here is the log:

2021-07-26T04:09:42.710+0200	INFO	gate.java.client.player	proxy/switch.go:307	Player was kicked from server	{"name": "xXNurioXx", "id": "6136bbb2-2d67-4fb3-b200-d0a5cb28f385", "server": "server1", "reason": "Internal server connection error"}

How to replicate:

• Clone this repository
• Start the extension example with the example servers
• Connect yourself to the server
• Execute de /op {username} command.

You will get kicked from the server and you will not be able to reconnect to it.

#23

The official Minecraft authentication URL is https://sessionserver.mojang.com/session/minecraft/xxx. However, in some cases, the server can use its own authentication service (implementing Mojang's authentication API).

For example: https://my.authentication.site/api/xxx.

I know of some proven solutions to implement this authentication service: authlib-injector works on servers and clients, and Blessing-Skin is a web service.

By making the variable mojangURL in gate/pkg/edition/java/auth/authenticator.go configurable, Gate will be able to implement third-party authentication.

This can be cool :)

• Reload on config file update
• Reload on SIGHUB

Imagine we port https://github.com/PrismarineJS/node-minecraft-protocol to Go such that Gate never ever needs to implement Minecraft protocol version changes again for every new version. It uses https://github.com/PrismarineJS/minecraft-data internally.

Recently I was working with Gate as my proxy-server, but for some reason, when the player join on another server their tab-names didn't update.

First authentication server:

First hub server:

I'm running a private fork from Gate for my network for that, but it's still on latest version of Gate and I didn't made any changes for Scoreboard Teams packet.

• reuse allocated packet structs
• use distinct bufpool for each packet type

The protocol changed (significantly?) in 1.18.

Some other proxies have updated already:

• https://github.com/GeyserMC/Geyser
• https://github.com/GeyserMC/MCProtocolLib/commits/master

... need to update this too. will have a look at doing it

Player gets disconnected when changing the tab list name.

2021-07-21T11:17:52.531+0200    DEBUG   gate.java.server        proxy/connection.go:408 Update compression      {"threshold": 512}
2021-07-21T11:17:52.567+0200    INFO    gate.java.client.player.serverConn.backendTransitionSession     proxy/session_backend_transition.go:203 Player joining initial server   {"name": "shawshark", "id": "be7ef425-f3a4-4b83-b676-71b2274ec577", "serverName": "server", "serverAddr": "127.0.0.1:21289"}
2021-07-21T11:17:53.654+0200    DEBUG   gate.java.server        proxy/connection.go:148 silentErr: error reading next packet, unrecoverable and closing connection      {"err": "error decoding packet (type: *packet.PlayerListItem, id: 32, protocol: 754, direction: ClientBound): unknown PlayerListItemAction 3"}
2021-07-21T11:17:53.654+0200    DEBUG   gate.java.server        proxy/connection.go:112 Error reading packet, closing connection        {"err": "error decoding packet (type: *packet.PlayerListItem, id: 32, protocol: 754, direction: ClientBound): unknown PlayerListItemAction 3"}
2021-07-21T11:17:53.654+0200    INFO    gate.java.client.player proxy/switch.go:307     Player was kicked from server   {"name": "shawshark", "id": "be7ef425-f3a4-4b83-b676-71b2274ec577", "server": "server", "reason": "Internal server connection error"}
2021-07-21T11:17:53.654+0200    DEBUG   gate.java.client        proxy/connection.go:112 Error reading packet, closing connection        {"err": "error reading varint frame: error reading varint: read tcp #:25565->#:50598: use of closed network connection"}
2021-07-21T11:17:53.655+0200    INFO    gate.java.client.player proxy/player.go:421     Player has been disconnected    {"name": "shawshark", "id": "be7ef425-f3a4-4b83-b676-71b2274ec577", "reason": "§cKicked from \"server\": Internal server connection error"}

The source of the timeout is

Maybe we should provide verbosity leveled logging more and provide a -v flag instead as an alias to -d that sets the verbosity to 100.
More on that what I mean https://kubernetes.io/docs/concepts/cluster-administration/system-logs/#log-verbosity-level

Currently, I'm working on a different session handler after login state to listen incoming Flying packets.
But for some reason, I cannot register some packets in Server and Client bounds due to duplicate packet id.

I made a FallStatus packet which is designed with ID 0x03 in Play state for Protocol Version 47 (1.8.8), but when I try to register it, gate crashs and a panic message is sent with a specific message about a duplicate ID from Protocol Version 335 (1.12) of Packet.Chat.
Can not register packet type packet.Chat with id 0x33 for protocol 335 because another packet is already registered
I'm registering those packets like that:

Play.ServerBound.Register(&p.FallStatus{},
  m(0x03, version.Minecraft_1_8))

Add more plugin support with script languages: lua and tengo (this is for the general folks that just want to get startet quick and easy)

Add APIs for more player interaction -> boss bar, player tab list, action bar, titles, maybe even scoreboards

Need to make changes from 755 -> 756.

It looks like just a simple handshake padding change.

Currently 1.17 works, 1.17.1 fails.

What are the features that need to be implemented on this project to be a mature project?

As I mentioned at #36 and #37 there is a problem with the extended example.
It is using an old version of the gate proxy and that one has critical bugs.

This should be fixed to avoid future confusion and bad perceptions of this project. 📈💪

Report by @LaysDragon:

announceForge options seems not working at all? (server list only show vanilla server)
Its a strange options,it in the status field in the example config(https://github.com/minekube/gate/blob/master/config.yml) but outside the status field in go struct(https://github.com/minekube/gate/blob/master/pkg/edition/java/config/config.go)
And i still not success set it work with forge server yet:thinking: