minecraft-java-edition-speedrunning / mcsr-serversiderng-1.16.1 Goto Github PK

Version Information

7.0.0

Expected Behavior

Getting a response about run submission after /seed etc. on linux

Actual Behavior

When I open the game or create a new world with the mod enabled, I get errors in the log such as "Failed to create new RNGSession". Also when doing /seed there's no message about the run submission. Log file with more details attached below.

Reproduction Steps

Opening the game, creating a new world.

System Information

• Java Version: 19.0.2
• CPU: Intel i5-12400F
• GPU: AMD RX 6600
• OS: Fedora Linux 37

Other Information

Log file:
log file.zip
List of mods:

My game just instantly crashes when trying to start it with this mod.

Hello, I might have found a serious issue with the mod.
Full disclaimer: This is my opinion, I might have a faulty thought process.

In its current state, the server supplies a seed from which the client derives seeds for the random generators related to each implemented "random" in-game event.
Having a separate random generator for each random event does indeed make it easy for a mod to verify a run's integrity by simply checking if the runner's random generator behaves the same way as theirs.
In my opinion, this approach is fatally flawed.
By fetching the seed the server supplies at the beginning of a run, a runner can simply "calculate their future luck" by generating the stream of events a LRNG with the given seed should produce (similar to how people verifying runs would) prior to running, thus giving them crucial information to decide on whether to request a new seed from the server ("resetting").

tl;dr: With the correct skills, someone could make it so that their drop rates are significantly higher than they should by automatically skipping runs in which the seed isn't in their favor.

One might suggest leaving the game logic as-is; using one LRNG for all random events; But this approach also bears fatal problems for the mod which I will not explain here.

edit: removed a part since it might be misinterpretable

Version Information

serverSideRNG-7.0.0.jar

Expected Behavior

The game should load properly (as Java 8 is the default Java version for 1.16).

Actual Behavior

The game crashes on startup: https://mclo.gs/alcMiEx

Reproduction Steps

Attempt to load this mod with Java 8.

System Information

• Java Version: 1.8.0_292
• CPU: n/a
• GPU: n/a

Other Information

This is the same bug as VoidXWalker/WorldPreview#20, the same fix should work (VoidXWalker/WorldPreview#23)